GNU bug report logs - #37987
Add gitg

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37987 in the body.
You can then email your comments to 37987 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: guix-patches <at> gnu.org
Subject: Add gitg
Date: Wed, 30 Oct 2019 10:35:01 +0100

[Message part 1 (text/plain, inline)]

This patch adds gitg, the GNOME graphical interface to git.

The package contains failing tests, so I've disabled them altogether
for now.  I've tried setting up an X display, thinking it could aid the
situation, but that only leads to a timeout in another test.  I'm a bit
at a loss here.

Regards,

Leo

[0001-gnu-Add-gitg.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: 37987 <at> debbugs.gnu.org
Subject: Re: [bug#37987] Add gitg
Date: Wed, 30 Oct 2019 11:00:11 +0100

Hello Leo,

> The package contains failing tests, so I've disabled them altogether
> for now.  I've tried setting up an X display, thinking it could aid the
> situation, but that only leads to a timeout in another test.  I'm a bit
> at a loss here.

Your patch LGTM. About failing test, I see that nix runs them and has a
small fix to substitute bash path:

--8<---------------cut here---------------start------------->8---
    substituteInPlace tests/libgitg/test-commit.vala --replace "/bin/bash" "${bash}/bin/bash"
--8<---------------cut here---------------end--------------->8---

Have you tried something like that?

Thanks,

Mathieu

Message #14 received at 37987 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: m.othacehe <at> gmail.com
Cc: 37987 <at> debbugs.gnu.org
Subject: [bug#37987] Add gitg
Date: Wed, 30 Oct 2019 13:56:51 +0100

[Message part 1 (text/plain, inline)]

> Your patch LGTM. About failing test, I see that nix runs them and has
> a
> small fix to substitute bash path:
> 
> --8<---------------cut here---------------start------------->8---
>     substituteInPlace tests/libgitg/test-commit.vala --replace
> "/bin/bash" 
> "${bash}/bin/bash"
> --8<---------------cut here---------------end--------------->8---
> 
> Have you tried something like that?
That does seem to work. I've updated the patch.

Regards,

Leo

[0001-gnu-Add-gitg.patch (text/x-patch, attachment)]

Message #19 received at 37987-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>
Cc: m.othacehe <at> gmail.com, 37987-done <at> debbugs.gnu.org
Subject: Re: [bug#37987] Add gitg
Date: Wed, 30 Oct 2019 17:18:45 +0100

>> Have you tried something like that?
> That does seem to work. I've updated the patch.

Pushed with a minor edit to home-page field!

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.