GNU bug report logs - #37987
Add gitg

Previous Next

Package: guix-patches;

Reported by: Leo Prikler <leo.prikler <at> student.tugraz.at>

Date: Wed, 30 Oct 2019 09:36:01 UTC

Severity: normal

Done: Mathieu Othacehe <m.othacehe <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: m.othacehe <at> gmail.com
Cc: 37987 <at> debbugs.gnu.org
Subject: [bug#37987] Add gitg
Date: Wed, 30 Oct 2019 13:56:51 +0100
[Message part 1 (text/plain, inline)]
> Your patch LGTM. About failing test, I see that nix runs them and has
> a
> small fix to substitute bash path:
> 
> --8<---------------cut here---------------start------------->8---
>     substituteInPlace tests/libgitg/test-commit.vala --replace
> "/bin/bash" 
> "${bash}/bin/bash"
> --8<---------------cut here---------------end--------------->8---
> 
> Have you tried something like that?
That does seem to work. I've updated the patch.

Regards,

Leo
[0001-gnu-Add-gitg.patch (text/x-patch, attachment)]

This bug report was last modified 5 years and 263 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.