GNU bug report logs - #37891
[PATCH] Clean up error on wrong major mode in package-menu-mode

Previous Next

Full log

View this message in rfc822 format

From: Stefan Kangas <stefan <at> marxist.se>
To: 37891 <at> debbugs.gnu.org
Subject: bug#37891: [PATCH] Clean up error on wrong major mode in package-menu-mode
Date: Wed, 23 Oct 2019 18:09:21 +0200

[Message part 1 (text/plain, inline)]

Four package-menu-mode specific commands currently signal an error if
called when not in package-menu-mode.  One of them uses 'user-error',
the others 'error'.  All other commands don't signal an error.

The attached patch makes the behaviour more consistent by:
1) Factoring out the error signalling into a new function to make it
more consistent.
2) Calling this function in all other relevant package-mode-menu commands.

Any comments?

Best regards,
Stefan Kangas

[0001-Clean-up-error-on-wrong-major-mode-in-package-menu-m.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.