GNU bug report logs - #37891
[PATCH] Clean up error on wrong major mode in package-menu-mode

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefan <at> marxist.se>

Date: Wed, 23 Oct 2019 16:10:02 UTC

Severity: normal

Tags: patch

Fixed in version 27.1

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37891 in the body.
You can then email your comments to 37891 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#37891; Package emacs. (Wed, 23 Oct 2019 16:10:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Stefan Kangas <stefan <at> marxist.se>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 23 Oct 2019 16:10:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Clean up error on wrong major mode in package-menu-mode
Date: Wed, 23 Oct 2019 18:09:21 +0200

[Message part 1 (text/plain, inline)]
Four package-menu-mode specific commands currently signal an error if
called when not in package-menu-mode.  One of them uses 'user-error',
the others 'error'.  All other commands don't signal an error.

The attached patch makes the behaviour more consistent by:
1) Factoring out the error signalling into a new function to make it
more consistent.
2) Calling this function in all other relevant package-mode-menu commands.

Any comments?

Best regards,
Stefan Kangas

[0001-Clean-up-error-on-wrong-major-mode-in-package-menu-m.patch (application/octet-stream, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#37891; Package emacs. (Thu, 07 Nov 2019 03:15:02 GMT) Full text and rfc822 format available.

Message #8 received at 37891 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: 37891 <at> debbugs.gnu.org
Subject: Re: bug#37891: [PATCH] Clean up error on wrong major mode in
 package-menu-mode
Date: Thu, 07 Nov 2019 04:14:42 +0100

close 37891 27.1
thanks

Stefan Kangas <stefan <at> marxist.se> writes:

> Four package-menu-mode specific commands currently signal an error if
> called when not in package-menu-mode.  One of them uses 'user-error',
> the others 'error'.  All other commands don't signal an error.
>
> The attached patch makes the behaviour more consistent by:
> 1) Factoring out the error signalling into a new function to make it
> more consistent.
> 2) Calling this function in all other relevant package-mode-menu commands.
>
> Any comments?

No comments in 14 days; now pushed to master as commit ddb797cf4c.

Best regards,
Stefan Kangas
bug marked as fixed in version 27.1, send any further explanations to 37891 <at> debbugs.gnu.org and Stefan Kangas <stefan <at> marxist.se> Request was from Stefan Kangas <stefan <at> marxist.se> to control <at> debbugs.gnu.org. (Thu, 07 Nov 2019 03:15:03 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 05 Dec 2019 12:24:06 GMT) Full text and rfc822 format available.
This bug report was last modified 5 years and 281 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.