GNU bug report logs - #37891
[PATCH] Clean up error on wrong major mode in package-menu-mode

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefan <at> marxist.se>

Date: Wed, 23 Oct 2019 16:10:02 UTC

Severity: normal

Tags: patch

Fixed in version 27.1

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

Full log

Message #10 received at control <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: 37891 <at> debbugs.gnu.org
Subject: Re: bug#37891: [PATCH] Clean up error on wrong major mode in
 package-menu-mode
Date: Thu, 07 Nov 2019 04:14:42 +0100

close 37891 27.1
thanks

Stefan Kangas <stefan <at> marxist.se> writes:

> Four package-menu-mode specific commands currently signal an error if
> called when not in package-menu-mode.  One of them uses 'user-error',
> the others 'error'.  All other commands don't signal an error.
>
> The attached patch makes the behaviour more consistent by:
> 1) Factoring out the error signalling into a new function to make it
> more consistent.
> 2) Calling this function in all other relevant package-mode-menu commands.
>
> Any comments?

No comments in 14 days; now pushed to master as commit ddb797cf4c.

Best regards,
Stefan Kangas
This bug report was last modified 5 years and 281 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.