GNU bug report logs - #37882
linux-module-build-system doesn't accept make-flags

Previous Next

Full log

Message #8 received at 37882 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 37882 <at> debbugs.gnu.org
Subject: [PATCH] build-system/linux-module: Accept a #:make-flags keyword.
Date: Fri, 25 Oct 2019 21:37:31 +0200

* guix/build-system/linux-module.scm (linux-module-build): Accept a
MAKE-FLAGS argument.
<builder>: Pass it on.
---

Efraim,

Is this in any way related to the topic coming up on IRC last week, or just a coincidence?

In any case, I'd written the following simple fix but never merged it because I have yet to meet a module with a legitimate need for it.  It works, though.

Kind regards,

T G-R

 guix/build-system/linux-module.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/guix/build-system/linux-module.scm b/guix/build-system/linux-module.scm
index 6084d22210..dde2423434 100644
--- a/guix/build-system/linux-module.scm
+++ b/guix/build-system/linux-module.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2019 Danny Milosavljevic <dannym <at> scratchpost.org>
+;;; Copyright © 2019 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -120,6 +121,7 @@
 (define* (linux-module-build store name inputs
                              #:key
                              (search-paths '())
+                             (make-flags '())
                              (tests? #t)
                              (phases '(@ (guix build linux-module-build-system)
                                          %standard-phases))
@@ -146,6 +148,7 @@
                                            search-paths)
                      #:phases ,phases
                      #:system ,system
+                     #:make-flags ,make-flags
                      #:tests? ,tests?
                      #:outputs %outputs
                      #:inputs %build-inputs)))
-- 
2.23.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.