GNU bug report logs - #37882
linux-module-build-system doesn't accept make-flags

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37882 in the body.
You can then email your comments to 37882 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: bug-guix <at> gnu.org
Subject: linux-module-build-system doesn't accept make-flags
Date: Wed, 23 Oct 2019 11:06:58 +0300

[Message part 1 (text/plain, inline)]

In (guix build linux-module-build-system) the build phase looks for
make-flags, but 'make-flags' doesn't exist in (guix build-system
linux-module), making it not really supported.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 37882 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 37882 <at> debbugs.gnu.org
Subject: [PATCH] build-system/linux-module: Accept a #:make-flags keyword.
Date: Fri, 25 Oct 2019 21:37:31 +0200

* guix/build-system/linux-module.scm (linux-module-build): Accept a
MAKE-FLAGS argument.
<builder>: Pass it on.
---

Efraim,

Is this in any way related to the topic coming up on IRC last week, or just a coincidence?

In any case, I'd written the following simple fix but never merged it because I have yet to meet a module with a legitimate need for it.  It works, though.

Kind regards,

T G-R

 guix/build-system/linux-module.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/guix/build-system/linux-module.scm b/guix/build-system/linux-module.scm
index 6084d22210..dde2423434 100644
--- a/guix/build-system/linux-module.scm
+++ b/guix/build-system/linux-module.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2019 Danny Milosavljevic <dannym <at> scratchpost.org>
+;;; Copyright © 2019 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -120,6 +121,7 @@
 (define* (linux-module-build store name inputs
                              #:key
                              (search-paths '())
+                             (make-flags '())
                              (tests? #t)
                              (phases '(@ (guix build linux-module-build-system)
                                          %standard-phases))
@@ -146,6 +148,7 @@
                                            search-paths)
                      #:phases ,phases
                      #:system ,system
+                     #:make-flags ,make-flags
                      #:tests? ,tests?
                      #:outputs %outputs
                      #:inputs %build-inputs)))
-- 
2.23.0

Message #11 received at 37882 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 37882 <at> debbugs.gnu.org
Subject: Re: bug#37882: [PATCH] build-system/linux-module: Accept a
 #:make-flags keyword.
Date: Sun, 27 Oct 2019 10:18:06 +0200

[Message part 1 (text/plain, inline)]

On Fri, Oct 25, 2019 at 09:37:31PM +0200, Tobias Geerinckx-Rice via Bug reports for GNU Guix wrote:
> * guix/build-system/linux-module.scm (linux-module-build): Accept a
> MAKE-FLAGS argument.
> <builder>: Pass it on.
> ---
> 
> Efraim,
> 
> Is this in any way related to the topic coming up on IRC last week, or just a coincidence?
> 
> In any case, I'd written the following simple fix but never merged it because I have yet to meet a module with a legitimate need for it.  It works, though.
> 

I thought I had a use-case for it but it turns out I'm pretty sure I
didn't need it in the end. It was more of surprise that it was in one
place and not another.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 37882 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: Tobias Geerinckx-Rice <me <at> tobias.gr>, 37882 <at> debbugs.gnu.org
Subject: Re: bug#37882: [PATCH] build-system/linux-module: Accept a
 #:make-flags keyword.
Date: Mon, 4 Nov 2019 07:26:11 +0100

[Message part 1 (text/plain, inline)]

On Sun, 27 Oct 2019 10:18:06 +0200
Efraim Flashner <efraim <at> flashner.co.il> wrote:

> > In any case, I'd written the following simple fix but never merged it because I have yet to meet a module with a legitimate need for it.  It works, though.
> >   
> It was more of surprise that it was in one
> place and not another.

Whoops.  LGTM anyway!

[Message part 2 (application/pgp-signature, inline)]

Message #19 received at 37882-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 37882-done <at> debbugs.gnu.org
Subject: Re: bug#37882: [PATCH] build-system/linux-module: Accept a
 #:make-flags keyword.
Date: Wed, 4 Dec 2019 11:28:14 +0200

[Message part 1 (text/plain, inline)]

I pushed this patch

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.