GNU bug report logs - #37874
27.0.50; A recent commit broke doc-view (and pdf-tools)

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tassilo Horn <tsdh <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#37874: closed (27.0.50; A recent commit broke doc-view (and
 pdf-tools))
Date: Fri, 25 Oct 2019 20:24:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 25 Oct 2019 22:23:02 +0200
with message-id <87o8y4wp5l.fsf <at> gnu.org>
and subject line Re: bug#37874: AW: Re: bug#37578: closed (Re: bug#37578: 26.3; image-mode does not display the bottom edge of a tall image)
has caused the debbugs.gnu.org bug report #37874,
regarding 27.0.50; A recent commit broke doc-view (and pdf-tools)
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
37874: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37874
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Andreas Politz <politza <at> hochschule-trier.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; A recent commit broke doc-view (and pdf-tools)
Date: Tue, 22 Oct 2019 20:27:37 +0200

Since  commit  9c66b09950cf2db50eb6d818656a268ef750bfe6  image-next-line
returns the current window-vscroll as a  unit of pixels.  Before, it was
returning  it  in  terms  of  character-height.   This  breaks  multiple
functions in doc-view, which are comparing  those values to the value of
(window-vscroll).  If this change is going to stay doc-view.el needs to
be adapted as well.

-ap

[Message part 3 (message/rfc822, inline)]

From: Tassilo Horn <tsdh <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 37874-done <at> debbugs.gnu.org, 37578 <at> debbugs.gnu.org,
 politza <at> hochschule-trier.de
Subject: Re: bug#37874: AW: Re: bug#37578: closed (Re: bug#37578: 26.3;
 image-mode does not display the bottom edge of a tall image)
Date: Fri, 25 Oct 2019 22:23:02 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

>> > I have already adapted my package in a branch.  And I think the
>> > required changes are straightforward. I suppose the same holds for
>> > doc-view.
>> 
>> Ok, great. I'll adapt doc-view.el ASAP and then close this
>> issue. Thanks for your report.

I've fixed doc-view just now (bug#37874) with commit a0f7ea5999.

> Thanks, and sorry again for not being more vigilant.

You're welcome,
Tassilo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.