GNU bug report logs - #37874
27.0.50; A recent commit broke doc-view (and pdf-tools)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37874 in the body.
You can then email your comments to 37874 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andreas Politz <politza <at> hochschule-trier.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; A recent commit broke doc-view (and pdf-tools)
Date: Tue, 22 Oct 2019 20:27:37 +0200

Since  commit  9c66b09950cf2db50eb6d818656a268ef750bfe6  image-next-line
returns the current window-vscroll as a  unit of pixels.  Before, it was
returning  it  in  terms  of  character-height.   This  breaks  multiple
functions in doc-view, which are comparing  those values to the value of
(window-vscroll).  If this change is going to stay doc-view.el needs to
be adapted as well.

-ap

Message #8 received at 37874 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Tassilo Horn <tsdh <at> gnu.org>
Cc: 37874 <at> debbugs.gnu.org, 37578 <at> debbugs.gnu.org, politza <at> hochschule-trier.de
Subject: Re: bug#37578: closed (Re: bug#37578: 26.3; image-mode does not
 display the bottom edge of a tall image)
Date: Wed, 23 Oct 2019 20:58:15 +0300

> From: Tassilo Horn <tsdh <at> gnu.org>
> Cc: ynyaaa <at> gmail.com,  37578 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
> Date: Wed, 23 Oct 2019 18:07:53 +0200
> 
> > image-mode.el was scrolling images vertically in units of canonical
> > character height, so it couldn't handle the last portion of an image
> > smaller than the height of one character.
> >
> > This is now fixed on the master branch.
> 
> Your change 9c66b09950cf2db50eb6d818656a268ef750bfe6 broke doc-view.el
> and the pdf-tools package whose author already filed bug#37874 for the
> issue.
> 
> Could you have a look?  If the image functions stay returning pixel
> values that's ok but Andreas and I will need to adapt pdf-tools and
> doc-view.el accordingly.

Sorry, I didn't think some other package will use that function, it
looked like an internal subroutine.  I should have checked.

To answer your question: I see no reason to go back to character units
in this function.  We could either adapt the other packages to the
change, or add a new function that will work like the previous
image-next-line.  What would you prefer?  If the only problem is with
comparing against the value returned by window-vscroll, then perhaps
the former is easier and simpler?

Thanks.

Message #11 received at 37874 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Politz <politza <at> hochschule-trier.de>
To: Eli Zaretskii <eliz <at> gnu.org>, Tassilo Horn <tsdh <at> gnu.org>
Cc: 37874 <at> debbugs.gnu.org, 37578 <at> debbugs.gnu.org
Subject: AW: Re: bug#37578: closed (Re: bug#37578: 26.3; image-mode does not
 display the bottom edge of a tall image)
Date: Wed, 23 Oct 2019 20:49:04 +0200

[Message part 1 (text/plain, inline)]

I have already adapted my package in a branch.  And I think the required changes are straightforward. I suppose the same holds for doc-view.

Andreas

[Message part 2 (text/html, inline)]

Message #14 received at 37874 <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tsdh <at> gnu.org>
To: Andreas Politz <politza <at> hochschule-trier.de>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 37874 <at> debbugs.gnu.org, 37578 <at> debbugs.gnu.org
Subject: Re: AW: Re: bug#37578: closed (Re: bug#37578: 26.3;
 image-mode does not display the bottom edge of a tall image)
Date: Wed, 23 Oct 2019 20:56:48 +0200

On October 23, 2019 8:49:17 PM Andreas Politz <politza <at> hochschule-trier.de> 
wrote:

> I have already adapted my package in a branch.  And I think the required 
> changes are straightforward. I suppose the same holds for doc-view.

Ok, great. I'll adapt doc-view.el ASAP and then close this issue. Thanks 
for your report.

Bye,
Tassilo

Message #17 received at 37874 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Tassilo Horn <tsdh <at> gnu.org>
Cc: 37874 <at> debbugs.gnu.org, 37578 <at> debbugs.gnu.org, politza <at> hochschule-trier.de
Subject: Re: AW: Re: bug#37578: closed (Re: bug#37578: 26.3;
 image-mode does not display the bottom edge of a tall image)
Date: Wed, 23 Oct 2019 22:01:33 +0300

> From: Tassilo Horn <tsdh <at> gnu.org>
> CC: <37578 <at> debbugs.gnu.org>, <37874 <at> debbugs.gnu.org>
> Date: Wed, 23 Oct 2019 20:56:48 +0200
> 
> On October 23, 2019 8:49:17 PM Andreas Politz <politza <at> hochschule-trier.de> 
> wrote:
> 
> > I have already adapted my package in a branch.  And I think the required 
> > changes are straightforward. I suppose the same holds for doc-view.
> 
> Ok, great. I'll adapt doc-view.el ASAP and then close this issue. Thanks 
> for your report.

Thanks, and sorry again for not being more vigilant.

Message #22 received at 37874-done <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tsdh <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 37874-done <at> debbugs.gnu.org, 37578 <at> debbugs.gnu.org,
 politza <at> hochschule-trier.de
Subject: Re: bug#37874: AW: Re: bug#37578: closed (Re: bug#37578: 26.3;
 image-mode does not display the bottom edge of a tall image)
Date: Fri, 25 Oct 2019 22:23:02 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

>> > I have already adapted my package in a branch.  And I think the
>> > required changes are straightforward. I suppose the same holds for
>> > doc-view.
>> 
>> Ok, great. I'll adapt doc-view.el ASAP and then close this
>> issue. Thanks for your report.

I've fixed doc-view just now (bug#37874) with commit a0f7ea5999.

> Thanks, and sorry again for not being more vigilant.

You're welcome,
Tassilo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.