GNU bug report logs - #37825
[PATCH] gnu: bitcoin-abc: Update to 0.20.4.

Previous Next

Full log

Message #13 received at 37825 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 37825 <at> debbugs.gnu.org
Subject: Re: [bug#37825] [PATCH] gnu: bitcoin-abc: Update to 0.20.4.
Date: Fri, 01 Nov 2019 11:18:25 +0100

Marius Bakke skribis:

> Guillaume Le Vaillant <glv <at> posteo.net> writes:
>
>> * gnu/packages/finance.scm (bitcoin-abc): Update to 0.20.4.
>>   [source]: Fix uri.
>>   [inputs]: Use bdb-5.3 (bdb-4.8 is not supported).
>>   [arguments]: Add 'fix-tests' phase.
>
> [...]
>
>> +    (arguments
>> +     (substitute-keyword-arguments (package-arguments bitcoin-core)
>> +       ((#:phases phases)
>> +        `(modify-phases ,phases
>> +           (add-after 'unpack 'fix-tests
>> +             ;; Disable 'check-devtools' test which tries to run a
>> +             ;; python script that doesn't exist.
>> +             (lambda _
>> +               (substitute* "Makefile.in"
>> +                 (("^check-local: check-devtools")
>> +                  "check-local:"))
>> +               #t))))))
>
> Do you know why this script is not distributed?  Should we provide it,
> or was it a packaging mistake upstream?
>
> In any case I pushed this patch in
> 28d46d9d4317180b348ad5baeddad8ef25ed430a.  Thank you!

I'm not sure if it's a packaging mistake or a makefile mistake (if these
tests are not supposed to be run on a release version). They are tests
to check that some development tools work correctly (e.g. tools to
generate a header file which is included in the release tarball, to
update the copyright years in the headers, etc).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.