GNU bug report logs - #37825
[PATCH] gnu: bitcoin-abc: Update to 0.20.4.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37825 in the body.
You can then email your comments to 37825 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Guillaume Le Vaillant <glv <at> posteo.net>
Subject: [PATCH] gnu: bitcoin-abc: Update to 0.20.4.
Date: Sat, 19 Oct 2019 20:48:37 +0200

* gnu/packages/finance.scm (bitcoin-abc): Update to 0.20.4.
  [source]: Fix uri.
  [inputs]: Use bdb-5.3 (bdb-4.8 is not supported).
  [arguments]: Add 'fix-tests' phase.
---
 gnu/packages/finance.scm | 26 +++++++++++++++++++++++---
 1 file changed, 23 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index 960e3adeb3..0ab6489aeb 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -1133,15 +1133,35 @@ Trezor wallet.")
   (package
     (inherit bitcoin-core)
     (name "bitcoin-abc")
-    (version "0.19.8")
+    (version "0.20.4")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://download.bitcoinabc.org/"
-                                  version "/linux/src/bitcoin-abc-"
+                                  version "/src/bitcoin-abc-"
                                   version ".tar.gz"))
               (sha256
                (base32
-                "0ndvkxv5m8346bdhfqzgdiz1k9wyjycj05jp7daf9pml3cw79sz5"))))
+                "0fld54z3l7z7k5n35rrjichjnx37j9xp0rv8i69m3x4qfj1xk2np"))))
+    (inputs
+     `(("bdb" ,bdb-5.3)
+       ("boost" ,boost)
+       ("libevent" ,libevent)
+       ("miniupnpc" ,miniupnpc)
+       ("openssl" ,openssl)
+       ("protobuf" ,protobuf)
+       ("qtbase" ,qtbase)))
+    (arguments
+     (substitute-keyword-arguments (package-arguments bitcoin-core)
+       ((#:phases phases)
+        `(modify-phases ,phases
+           (add-after 'unpack 'fix-tests
+             ;; Disable 'check-devtools' test which tries to run a
+             ;; python script that doesn't exist.
+             (lambda _
+               (substitute* "Makefile.in"
+                 (("^check-local: check-devtools")
+                  "check-local:"))
+               #t))))))
     (home-page "https://www.bitcoinabc.org/")
     (synopsis "Bitcoin ABC peer-to-peer full node for the Bitcoin Cash protocol")
     (description
-- 
2.23.0

Message #10 received at 37825-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Guillaume Le Vaillant <glv <at> posteo.net>, 37825-done <at> debbugs.gnu.org
Cc: Guillaume Le Vaillant <glv <at> posteo.net>
Subject: Re: [bug#37825] [PATCH] gnu: bitcoin-abc: Update to 0.20.4.
Date: Fri, 01 Nov 2019 00:23:45 +0100

[Message part 1 (text/plain, inline)]

Guillaume Le Vaillant <glv <at> posteo.net> writes:

> * gnu/packages/finance.scm (bitcoin-abc): Update to 0.20.4.
>   [source]: Fix uri.
>   [inputs]: Use bdb-5.3 (bdb-4.8 is not supported).
>   [arguments]: Add 'fix-tests' phase.

[...]

> +    (arguments
> +     (substitute-keyword-arguments (package-arguments bitcoin-core)
> +       ((#:phases phases)
> +        `(modify-phases ,phases
> +           (add-after 'unpack 'fix-tests
> +             ;; Disable 'check-devtools' test which tries to run a
> +             ;; python script that doesn't exist.
> +             (lambda _
> +               (substitute* "Makefile.in"
> +                 (("^check-local: check-devtools")
> +                  "check-local:"))
> +               #t))))))

Do you know why this script is not distributed?  Should we provide it,
or was it a packaging mistake upstream?

In any case I pushed this patch in
28d46d9d4317180b348ad5baeddad8ef25ed430a.  Thank you!

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 37825 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 37825 <at> debbugs.gnu.org
Subject: Re: [bug#37825] [PATCH] gnu: bitcoin-abc: Update to 0.20.4.
Date: Fri, 01 Nov 2019 11:18:25 +0100

Marius Bakke skribis:

> Guillaume Le Vaillant <glv <at> posteo.net> writes:
>
>> * gnu/packages/finance.scm (bitcoin-abc): Update to 0.20.4.
>>   [source]: Fix uri.
>>   [inputs]: Use bdb-5.3 (bdb-4.8 is not supported).
>>   [arguments]: Add 'fix-tests' phase.
>
> [...]
>
>> +    (arguments
>> +     (substitute-keyword-arguments (package-arguments bitcoin-core)
>> +       ((#:phases phases)
>> +        `(modify-phases ,phases
>> +           (add-after 'unpack 'fix-tests
>> +             ;; Disable 'check-devtools' test which tries to run a
>> +             ;; python script that doesn't exist.
>> +             (lambda _
>> +               (substitute* "Makefile.in"
>> +                 (("^check-local: check-devtools")
>> +                  "check-local:"))
>> +               #t))))))
>
> Do you know why this script is not distributed?  Should we provide it,
> or was it a packaging mistake upstream?
>
> In any case I pushed this patch in
> 28d46d9d4317180b348ad5baeddad8ef25ed430a.  Thank you!

I'm not sure if it's a packaging mistake or a makefile mistake (if these
tests are not supposed to be run on a release version). They are tests
to check that some development tools work correctly (e.g. tools to
generate a header file which is included in the release tarball, to
update the copyright years in the headers, etc).

Message #16 received at 37825 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Guillaume Le Vaillant <glv <at> posteo.net>
Cc: 37825 <at> debbugs.gnu.org
Subject: Re: [bug#37825] [PATCH] gnu: bitcoin-abc: Update to 0.20.4.
Date: Sun, 03 Nov 2019 18:11:50 +0100

[Message part 1 (text/plain, inline)]

Guillaume Le Vaillant <glv <at> posteo.net> writes:

> Marius Bakke skribis:
>
>> Guillaume Le Vaillant <glv <at> posteo.net> writes:
>>
>>> * gnu/packages/finance.scm (bitcoin-abc): Update to 0.20.4.
>>>   [source]: Fix uri.
>>>   [inputs]: Use bdb-5.3 (bdb-4.8 is not supported).
>>>   [arguments]: Add 'fix-tests' phase.
>>
>> [...]
>>
>>> +    (arguments
>>> +     (substitute-keyword-arguments (package-arguments bitcoin-core)
>>> +       ((#:phases phases)
>>> +        `(modify-phases ,phases
>>> +           (add-after 'unpack 'fix-tests
>>> +             ;; Disable 'check-devtools' test which tries to run a
>>> +             ;; python script that doesn't exist.
>>> +             (lambda _
>>> +               (substitute* "Makefile.in"
>>> +                 (("^check-local: check-devtools")
>>> +                  "check-local:"))
>>> +               #t))))))
>>
>> Do you know why this script is not distributed?  Should we provide it,
>> or was it a packaging mistake upstream?
>>
>> In any case I pushed this patch in
>> 28d46d9d4317180b348ad5baeddad8ef25ed430a.  Thank you!
>
> I'm not sure if it's a packaging mistake or a makefile mistake (if these
> tests are not supposed to be run on a release version). They are tests
> to check that some development tools work correctly (e.g. tools to
> generate a header file which is included in the release tarball, to
> update the copyright years in the headers, etc).

I see, thanks for the explanation.  Perhaps we are simply using the
wrong Makefile target?  By default gnu-build-system runs 'make check' in
the 'check' phase: some packages use 'make test' or 'make ci' instead.

Something to look out for in the next version.  :-)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.