GNU bug report logs - #37621
[PATCH] Remove XEmacs compat code from edt.el

Previous Next

Full log

Message #11 received at 37621 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 37621 <at> debbugs.gnu.org
Subject: Re: bug#37621: [PATCH] Remove XEmacs compat code from edt.el
Date: Mon, 7 Oct 2019 14:58:39 +0200

Basil L. Contovounesios <contovob <at> tcd.ie> writes:

> Hopefully no-one will complain about these constants disappearing
> without first being made obsolete (I won't). ;)

I thought that it was fine to just remove them when they are only
relevant for XEmacs or backwards compatibility?  I could of course
declare them obsolete instead if that's preferable.

> The calls to (function ...) can be removed, as they are redundant around
> evaluated lambdas.

Indeed, I had missed that.

> Otherwise looks fine to me, FWIW.

Thanks for reviewing.  I intend to push this in a couple of days if no
one raises any objections.

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.