GNU bug report logs - #37621
[PATCH] Remove XEmacs compat code from edt.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37621 in the body.
You can then email your comments to 37621 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Remove XEmacs compat code from edt.el
Date: Fri, 4 Oct 2019 16:08:36 +0200

[Message part 1 (text/plain, inline)]

Is this okay to commit?

Best regards,
Stefan Kangas

[0001-Remove-XEmacs-compat-code-from-edt.el.patch (text/x-patch, attachment)]

Message #8 received at 37621 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 37621 <at> debbugs.gnu.org
Subject: Re: bug#37621: [PATCH] Remove XEmacs compat code from edt.el
Date: Sat, 05 Oct 2019 22:12:55 +0100

Stefan Kangas <stefan <at> marxist.se> writes:

> @@ -310,23 +305,13 @@ edt-term
>  ;;;
>  ;;;     o edt-emulation-on      o edt-load-keys
>  ;;;
> -(defconst edt-emacs-variant (if (featurep 'emacs) "gnu" "xemacs")
> -  "Indicates Emacs variant:  GNU Emacs or XEmacs (aka Lucid Emacs).")
> -
> -(defconst edt-window-system (if (featurep 'emacs) window-system (console-type))
> -  "Indicates window system (in GNU Emacs) or console type (in XEmacs).")

Hopefully no-one will complain about these constants disappearing
without first being made obsolete (I won't). ;)

> @@ -2037,27 +1974,16 @@ edt-emulation-on
>  	    (setq edt-term term))))
>      (edt-load-keys nil))
>    ;; Make highlighting of selected text work properly for EDT commands.
> -  (if (featurep 'emacs)
> -      (progn
> -	(setq edt-orig-transient-mark-mode
> -              (default-value 'transient-mark-mode))
> -	(add-hook 'activate-mark-hook
> -		  (function
> -		   (lambda ()
> -		     (edt-select-mode t))))
> -	(add-hook 'deactivate-mark-hook
> -		  (function
> -		   (lambda ()
> -		     (edt-select-mode nil)))))
> -    (progn
> -      (add-hook 'zmacs-activate-region-hook
> -		(function
> -		 (lambda ()
> -		   (edt-select-mode t))))
> -      (add-hook 'zmacs-deactivate-region-hook
> -		(function
> -		 (lambda ()
> -		   (edt-select-mode nil))))))
> +  (setq edt-orig-transient-mark-mode
> +        (default-value 'transient-mark-mode))
> +  (add-hook 'activate-mark-hook
> +	    (function
> +	     (lambda ()
> +	       (edt-select-mode t))))
> +  (add-hook 'deactivate-mark-hook
> +	    (function
> +	     (lambda ()
> +	       (edt-select-mode nil))))

The calls to (function ...) can be removed, as they are redundant around
evaluated lambdas.

Otherwise looks fine to me, FWIW.

Thanks,

-- 
Basil

Message #11 received at 37621 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 37621 <at> debbugs.gnu.org
Subject: Re: bug#37621: [PATCH] Remove XEmacs compat code from edt.el
Date: Mon, 7 Oct 2019 14:58:39 +0200

Basil L. Contovounesios <contovob <at> tcd.ie> writes:

> Hopefully no-one will complain about these constants disappearing
> without first being made obsolete (I won't). ;)

I thought that it was fine to just remove them when they are only
relevant for XEmacs or backwards compatibility?  I could of course
declare them obsolete instead if that's preferable.

> The calls to (function ...) can be removed, as they are redundant around
> evaluated lambdas.

Indeed, I had missed that.

> Otherwise looks fine to me, FWIW.

Thanks for reviewing.  I intend to push this in a couple of days if no
one raises any objections.

Best regards,
Stefan Kangas

Message #16 received at 37621-close <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 37621-close <at> debbugs.gnu.org
Subject: Re: bug#37621: [PATCH] Remove XEmacs compat code from edt.el
Date: Wed, 9 Oct 2019 20:12:48 +0200

Stefan Kangas <stefan <at> marxist.se> writes:

> Thanks for reviewing.  I intend to push this in a couple of days if no
> one raises any objections.

Now pushed as commit c548a2af9b.

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.