GNU bug report logs - #36916
27.0.50; bug-reference: Make push button action customizable

Previous Next

Full log

View this message in rfc822 format

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 36916 <at> debbugs.gnu.org
Subject: bug#36916: 27.0.50; bug-reference: Make push button action customizable
Date: Sun, 04 Aug 2019 14:03:29 +0200

Michael Albinus <michael.albinus <at> gmx.de> writes:

> There is the minor mode `debbugs-browse-mode'. Enable it, that's it.

Hmm, ok.  But it's only a minor mode, so instead of having a global
setting, I have to add that minor mode to any place where it's needed.

So, why this does what I want, it's a bit disappointing: bug-reference
hardcodes browse-url, and browse-url can't be changed to handle new
types of urls specially, so the only thing we can do is to hijack
browse-url-browser-function buffer-locally.  Can't this even have side
effects?  What if the Magit revision buffer includes real links?  Oh -
no, I see, that works because the minor mode uses an :before-until
advice.  But it will break if something else binds or sets
browse-url-browser-function, right?

Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.