GNU bug report logs - #36916
27.0.50; bug-reference: Make push button action customizable

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36916 in the body.
You can then email your comments to 36916 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; bug-reference: Make push button action customizable
Date: Sun, 04 Aug 2019 04:30:26 +0200

Hi,

`bug-reference-push-button' hardcodes `browse-url' - I have to
redefine/override the complete function definition if I want to, say,
call `debbugs-gnu-bugs' instead of opening a browser when I click on the
bug button.  There is even only a url present in the button data, so I
have to parse out the button number from that url string.  Would be nice
if it would be easier to change the default behavior.

TIA, Michael.

Message #8 received at 36916 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: 36916 <at> debbugs.gnu.org
Subject: Re: bug#36916: 27.0.50; bug-reference: Make push button action
 customizable
Date: Sun, 04 Aug 2019 13:06:05 +0200

Michael Heerdegen <michael_heerdegen <at> web.de> writes:

> Hi,

Hi Michael.

> `bug-reference-push-button' hardcodes `browse-url' - I have to
> redefine/override the complete function definition if I want to, say,
> call `debbugs-gnu-bugs' instead of opening a browser when I click on the
> bug button.  There is even only a url present in the button data, so I
> have to parse out the button number from that url string.  Would be nice
> if it would be easier to change the default behavior.

There is the minor mode `debbugs-browse-mode'. Enable it, that's it.

See also (info "(debbugs-ug) Minor Mode")

> TIA, Michael.

Best regards, Michael.

Message #11 received at 36916 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 36916 <at> debbugs.gnu.org
Subject: Re: bug#36916: 27.0.50; bug-reference: Make push button action
 customizable
Date: Sun, 04 Aug 2019 14:03:29 +0200

Michael Albinus <michael.albinus <at> gmx.de> writes:

> There is the minor mode `debbugs-browse-mode'. Enable it, that's it.

Hmm, ok.  But it's only a minor mode, so instead of having a global
setting, I have to add that minor mode to any place where it's needed.

So, why this does what I want, it's a bit disappointing: bug-reference
hardcodes browse-url, and browse-url can't be changed to handle new
types of urls specially, so the only thing we can do is to hijack
browse-url-browser-function buffer-locally.  Can't this even have side
effects?  What if the Magit revision buffer includes real links?  Oh -
no, I see, that works because the minor mode uses an :before-until
advice.  But it will break if something else binds or sets
browse-url-browser-function, right?

Michael.

Message #14 received at 36916 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: 36916 <at> debbugs.gnu.org
Subject: Re: bug#36916: 27.0.50; bug-reference: Make push button action
 customizable
Date: Sun, 04 Aug 2019 16:49:52 +0200

Michael Heerdegen <michael_heerdegen <at> web.de> writes:

Hi Michael.

>> There is the minor mode `debbugs-browse-mode'. Enable it, that's it.
>
> Hmm, ok.  But it's only a minor mode, so instead of having a global
> setting, I have to add that minor mode to any place where it's needed.

I have in my .emacs

(add-hook 'bug-reference-mode-hook 'debbugs-browse-mode)
(add-hook 'bug-reference-prog-mode-hook 'debbugs-browse-mode)

> But it will break if something else binds or sets
> browse-url-browser-function, right?

Perhaps. Do we have this request from somebody?

> Michael.

Best regards, Michael.

Message #19 received at 36916 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: 36916 <at> debbugs.gnu.org
Subject: Re: bug#36916: 27.0.50; bug-reference: Make push button action
 customizable
Date: Wed, 14 Aug 2019 13:24:35 +0200

Michael Albinus <michael.albinus <at> gmx.de> writes:

Hi Michael.

>>> There is the minor mode `debbugs-browse-mode'. Enable it, that's it.
>>
>> Hmm, ok.  But it's only a minor mode, so instead of having a global
>> setting, I have to add that minor mode to any place where it's needed.
>
> I have in my .emacs
>
> (add-hook 'bug-reference-mode-hook 'debbugs-browse-mode)
> (add-hook 'bug-reference-prog-mode-hook 'debbugs-browse-mode)
>
>> But it will break if something else binds or sets
>> browse-url-browser-function, right?
>
> Perhaps. Do we have this request from somebody?

I believe we can close this request. There's nothing else to do.

>> Michael.

Best regards, Michael.

Message #24 received at 36916-done <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 36916-done <at> debbugs.gnu.org
Subject: Re: bug#36916: 27.0.50; bug-reference: Make push button action
 customizable
Date: Thu, 15 Aug 2019 20:14:06 +0200

Michael Albinus <michael.albinus <at> gmx.de> writes:

> I believe we can close this request. There's nothing else to do.

Ok, closing.  Thanks for discussing the issue.

Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.