GNU bug report logs - #36720
[PATCH] [Calc] Fix saving user-defined compositions

Previous Next

Package: emacs;

Reported by: Jack Coughlin <jack <at> jackc.me>

Date: Thu, 18 Jul 2019 16:08:02 UTC

Severity: normal

Tags: fixed, patch

Merged with 36719

Found in version 26.2

Fixed in version 27.1

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Jack Coughlin <jack <at> jackc.me>
To: 36720 <at> debbugs.gnu.org
Subject: bug#36720: [PATCH] [Calc] Fix saving user-defined compositions
Date: Thu, 18 Jul 2019 08:32:48 -0700

[Message part 1 (text/plain, inline)]
When saving a user-defined formula by specifying its ~z-~ key, or the
~M-x~ command name, its compositions are not saved correctly. The
attached patch fixes this behavior.

--- notes on the code change ---

~func~ is the calcFunc- symbol representing the formula.
~cmd~ is either the calc- symbol representing the command, or, if we
are saving just the formula, the calcFunc- symbol.

We always want to associate the composition forms to the calcFunc-
version. Observe for example that two lines below, this is the symbol
that we pull them from to save.


[0001-Fix-bug-when-saving-user-defined-commands-with-compo.patch (text/x-patch, attachment)]
This bug report was last modified 5 years and 256 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.