GNU bug report logs - #36720
[PATCH] [Calc] Fix saving user-defined compositions

Previous Next

Package: emacs;

Reported by: Jack Coughlin <jack <at> jackc.me>

Date: Thu, 18 Jul 2019 16:08:02 UTC

Severity: normal

Tags: fixed, patch

Merged with 36719

Found in version 26.2

Fixed in version 27.1

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36720 in the body.
You can then email your comments to 36720 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#36720; Package emacs. (Thu, 18 Jul 2019 16:08:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Jack Coughlin <jack <at> jackc.me>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 18 Jul 2019 16:08:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jack Coughlin <jack <at> jackc.me>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] [Calc] Fix saving user-defined compositions
Date: Thu, 18 Jul 2019 08:32:48 -0700

[Message part 1 (text/plain, inline)]
When saving a user-defined formula by specifying its ~z-~ key, or the
~M-x~ command name, its compositions are not saved correctly. The
attached patch fixes this behavior.

--- notes on the code change ---

~func~ is the calcFunc- symbol representing the formula.
~cmd~ is either the calc- symbol representing the command, or, if we
are saving just the formula, the calcFunc- symbol.

We always want to associate the composition forms to the calcFunc-
version. Observe for example that two lines below, this is the symbol
that we pull them from to save.


[0001-Fix-bug-when-saving-user-defined-commands-with-compo.patch (text/x-patch, attachment)]
Forcibly Merged 36719 36720. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Thu, 18 Jul 2019 16:17:02 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#36720; Package emacs. (Fri, 13 Sep 2019 01:51:02 GMT) Full text and rfc822 format available.

Message #10 received at 36720 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Jack Coughlin <jack <at> jackc.me>
Cc: 36720 <at> debbugs.gnu.org
Subject: Re: bug#36720: [PATCH] [Calc] Fix saving user-defined compositions
Date: Thu, 12 Sep 2019 21:50:17 -0400

tags 36720 fixed
close 36720 27.1
quit

Jack Coughlin <jack <at> jackc.me> writes:

> When saving a user-defined formula by specifying its ~z-~ key, or the
> ~M-x~ command name, its compositions are not saved correctly. The
> attached patch fixes this behavior.

Thanks, pushed to master.

a4c471c984 2019-09-12T20:25:30-04:00 "Fix saving user-defined calc commands with compositions (Bug#36720)"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=a4c471c98474a249948793aad386e4efc64a1c96
Added tag(s) fixed. Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Fri, 13 Sep 2019 01:51:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 27.1, send any further explanations to 36720 <at> debbugs.gnu.org and Jack Coughlin <jack <at> jackc.me> Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Fri, 13 Sep 2019 01:51:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 11 Oct 2019 11:24:10 GMT) Full text and rfc822 format available.
This bug report was last modified 5 years and 256 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.