GNU bug report logs - #36559
[PATCH] add rednotebook

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jesse Gibbons <jgibbons2357 <at> gmail.com>
Subject: bug#36559: closed (Re: [bug#36559] [PATCH] add rednotebook)
Date: Thu, 29 Aug 2019 17:19:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#36559: [PATCH] add rednotebook

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 36559 <at> debbugs.gnu.org.

-- 
36559: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36559
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Jesse Gibbons <jgibbons2357 <at> gmail.com>
Cc: 36559-done <at> debbugs.gnu.org
Subject: Re: [bug#36559] [PATCH] add rednotebook
Date: Thu, 29 Aug 2019 19:18:18 +0200

Hello,

Jesse Gibbons <jgibbons2357 <at> gmail.com> writes:

> From a5967bdbd15987438f158f1ae9bac2dc5a44c645 Mon Sep 17 00:00:00 2001
> From: Jesse Gibbons <jgibbons2357+guix <at> gmail.com>
> Date: Wed, 28 Aug 2019 20:35:29 -0600
> Subject: [PATCH] gnu: Add rednotebook.
>
>     * gnu/package/rednotebook.scm: New file.
>     * gnu/local.mk: Add it.
>     * gnu/packages/rednotebook.scm (rednotebook): New variable.

Applied. Thank you!

Regards,

-- 
Nicolas Goaziou

[Message part 3 (message/rfc822, inline)]

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] add rednotebook
Date: Mon, 8 Jul 2019 22:22:08 -0600

[Message part 4 (text/plain, inline)]

Patch is attached.
As explained in the comment I had to correct a few problems:
1. Tests always fail, but (in my experience) the final application is
stable.
2. rednotebook  uses the GI_TYPELIB_PATH and LD_LIBRARY_PATH to find
webkitgtk.

Furthermore:

- The commit message was killed/yanked from commit
  072e986ec808690db991e018d6ceee868b5b5f4a and adjusted.

- I made gnu/packages/journal.scm to add other similar journal/diary
  applications. Because I do not like naming sources for the only
  package defined within, especially when the package is simple, I
  recommend moving the jrnl package definition to it. Say the word and
  I will produce the patch to do this. Perhaps we should discuss the
  idea of organizing packages by function on the devel mailing list?

  - I also plan to define a package for other journal applications
    (like those listed between rednotebook and jrnl at
    <https://www.maketecheasier.com/best-journal-apps-for-linux/> and
    any other recommendations).

Knowing I am likely to err, I expect you (whoever reviews this patch)
to point out everything you don't like so I can fix it before you
approve and commit to savannah ;)

Thanks,
-Jesse

[0001-gnu-Add-rednotebook.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.