GNU bug report logs - #36558
When the user forgets the filename when using M-x grep

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36558 in the body.
You can then email your comments to 36558 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: bug-gnu-emacs <at> gnu.org
Subject: When the user forgets the filename when using M-x grep
Date: Tue, 09 Jul 2019 08:04:02 +0800

I don't think the M-x grep command has the ability for the user to
change the default prompt from the current

Run grep (like this): grep --color -nH --null -e

to the rather more sophisticated

Run grep (like this): grep --color -nH --null -e [] *

where "[]" represents where the cursor should be placed when prompting
the user.

Mentioning how to do so in (info "(emacs) Grep Searching")
or indeed, simply making it the new default, would save the 98% mistake
rate of users forgetting to add a filename and think there was no
matches (as outside of emacs this would hang without a filename,
alerting the user to the problem.)

Also M-x grep should detect that something tried to read stdin, meaning
the user forgot the filename, and then warn the user, instead of just
saying "No matches".

Currently this is a very high possibility the user will just do
Run grep (like this): grep --color -nH --null -e STRING
and forget FILENAMEs
creating an impossible situation, for which emacs currently just treats
as if the user did
Run grep (like this): grep --color -nH --null -e STRING /dev/null
which helps nobody.
At least emacs should catch this situation.

Message #8 received at 36558 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: 36558 <at> debbugs.gnu.org
Subject: Re: bug#36558: When the user forgets the filename when using M-x grep
Date: Wed, 10 Jul 2019 14:22:31 +0200

積丹尼 Dan Jacobson <jidanni <at> jidanni.org> writes:

> I don't think the M-x grep command has the ability for the user to
> change the default prompt from the current
>
> Run grep (like this): grep --color -nH --null -e
>
> to the rather more sophisticated
>
> Run grep (like this): grep --color -nH --null -e [] *
>
> where "[]" represents where the cursor should be placed when prompting
> the user.

I virtually never want to grep all files in a directory, so having to
hit `C-k' first would be a disadvantage, I think.  And this is the kind
of interface twiddling that annoys people used to the old defaults, so
I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #15 received at 36558 <at> debbugs.gnu.org (full text, mbox):

From: Tak Kunihiro <homeros.misasa <at> gmail.com>
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: 36558 <at> debbugs.gnu.org, Lars Ingebrigtsen <larsi <at> gnus.org>,
 tkk <at> misasa.okayama-u.ac.jp
Subject: Re: bug#36558: When the user forgets the filename when using M-x grep
Date: Thu, 11 Jul 2019 08:22:59 +0900

>> I don't think the M-x grep command has the ability for the user to
>> change the default prompt from the current
>>
>> Run grep (like this): grep --color -nH --null -e
>>
>> to the rather more sophisticated
>>
>> Run grep (like this): grep --color -nH --null -e [] *
>>
>> where "[]" represents where the cursor should be placed when prompting
>> the user.
>
> I virtually never want to grep all files in a directory, so having to
> hit `C-k' first would be a disadvantage, I think.  And this is the kind
> of interface twiddling that annoys people used to the old defaults, so
> I'm closing this bug report.

I had a similar thought.  I am OK now with following configuration.

(grep-apply-setting 'grep-command "grep -inHr . -e ")

Message #18 received at 36558 <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 36558 <at> debbugs.gnu.org
Subject: Re: bug#36558: When the user forgets the filename when using M-x grep
Date: Thu, 11 Jul 2019 08:38:06 +0800

>>>>> "LI" == Lars Ingebrigtsen <larsi <at> gnus.org> writes:
LI> 積丹尼 Dan Jacobson <jidanni <at> jidanni.org> writes:

>> I don't think the M-x grep command has the ability for the user to
>> change the default prompt from the current
>> 
>> Run grep (like this): grep --color -nH --null -e
>> 
>> to the rather more sophisticated
>> 
>> Run grep (like this): grep --color -nH --null -e [] *
>> 
>> where "[]" represents where the cursor should be placed when prompting
>> the user.

Indeed, grep.el is already so complicated...

LI> I virtually never want to grep all files in a directory, so having to

I'm the opposite.

LI> hit `C-k' first would be a disadvantage, I think.  And this is the kind
LI> of interface twiddling that annoys people used to the old defaults, so

I didn't say changing any defaults. I was asking for the "ability"...

LI> I'm closing this bug report.

Message #21 received at 36558 <at> debbugs.gnu.org (full text, mbox):

From: Tak Kunihiro <homeros.misasa <at> gmail.com>
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: 36558 <at> debbugs.gnu.org, Lars Ingebrigtsen <larsi <at> gnus.org>,
 tkk <at> misasa.okayama-u.ac.jp
Subject: Re: bug#36558: When the user forgets the filename when using M-x grep
Date: Thu, 11 Jul 2019 18:44:34 +0900

>>> I don't think the M-x grep command has the ability for the user to
>>> change the default prompt from the current
>>> 
>>> Run grep (like this): grep --color -nH --null -e
>>> 
>>> to the rather more sophisticated
>>> 
>>> Run grep (like this): grep --color -nH --null -e [] *
>>> 
>>> where "[]" represents where the cursor should be placed when prompting
>>> the user.

How about something like this?

(grep-apply-setting 'grep-command (cons "grep --color -nH --null -e  *" 28))

Message #24 received at 36558 <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: Tak Kunihiro <homeros.misasa <at> gmail.com>
Cc: 36558 <at> debbugs.gnu.org, Lars Ingebrigtsen <larsi <at> gnus.org>,
 tkk <at> misasa.okayama-u.ac.jp
Subject: Re: bug#36558: When the user forgets the filename when using M-x grep
Date: Fri, 12 Jul 2019 02:48:10 +0800

>>>>> "TK" == Tak Kunihiro <homeros.misasa <at> gmail.com> writes:
TK> How about something like this?
TK> (grep-apply-setting 'grep-command (cons "grep --color -nH --null -e  *" 28))

Ah! But I need something that I can put in (some grep hook in) .emacs. Something without the
flags hardwired into it. Something that just takes what grep gives me
and then adds "  *" to it and moves backwards like yours does without
hardwiring numbers. And even worth mentioning on grep's docstring too.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.