GNU bug report logs - #36453
[PATCH] Delegate to rectangle version in delim-col when appropriate

Previous Next

Full log

View this message in rfc822 format

From: Stefan Kangas <stefan <at> marxist.se>
To: 36453 <at> debbugs.gnu.org
Subject: bug#36453: [PATCH] Delegate to rectangle version in delim-col when appropriate
Date: Mon, 1 Jul 2019 01:40:24 +0200

[Message part 1 (text/plain, inline)]

Forwarding this from emacs-devel so it doesn't get lost.

Thanks,
Stefan Kangas

---------- Forwarded message ---------
From: Stefan Kangas <stefan <at> marxist.se>
Date: tors 30 maj 2019 kl 20:20
Subject: Re: [PATCH] Unit tests and lexical-binding for delim-col.el

Basil L. Contovounesios <contovob <at> tcd.ie> writes:
> > Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
> >> BTW, it would be nice to make it so that delimit-columns-region
> >> delegates to delimit-columns-rectangle when called with a rectangular
> >> region (i.e. using rectangle-mark-mode).
> >
> > Good idea.  How about the second patch attached here?

> I'm personally fine with this, but I think NEWS entries usually comprise
> a summary on the first line, followed by an elaboration in the body.
> I'm not very good at writing these, but here's one way to do that:
>
> Here's another possibility to reuse an existing NEWS entry under
> "Editing Changes":

Good thinking.  I think the version where we bundle this with other changes is
better.  But I would suggest to skip the implementation details.  See attached
patch.

Thanks,
Stefan Kangas

[0001-Delegate-to-rectangle-version-in-delim-col-when-appr-2.patch (application/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.