GNU bug report logs - #36453
[PATCH] Delegate to rectangle version in delim-col when appropriate

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36453 in the body.
You can then email your comments to 36453 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Delegate to rectangle version in delim-col when appropriate
Date: Mon, 1 Jul 2019 01:40:24 +0200

[Message part 1 (text/plain, inline)]

Forwarding this from emacs-devel so it doesn't get lost.

Thanks,
Stefan Kangas

---------- Forwarded message ---------
From: Stefan Kangas <stefan <at> marxist.se>
Date: tors 30 maj 2019 kl 20:20
Subject: Re: [PATCH] Unit tests and lexical-binding for delim-col.el

Basil L. Contovounesios <contovob <at> tcd.ie> writes:
> > Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
> >> BTW, it would be nice to make it so that delimit-columns-region
> >> delegates to delimit-columns-rectangle when called with a rectangular
> >> region (i.e. using rectangle-mark-mode).
> >
> > Good idea.  How about the second patch attached here?

> I'm personally fine with this, but I think NEWS entries usually comprise
> a summary on the first line, followed by an elaboration in the body.
> I'm not very good at writing these, but here's one way to do that:
>
> Here's another possibility to reuse an existing NEWS entry under
> "Editing Changes":

Good thinking.  I think the version where we bundle this with other changes is
better.  But I would suggest to skip the implementation details.  See attached
patch.

Thanks,
Stefan Kangas

[0001-Delegate-to-rectangle-version-in-delim-col-when-appr-2.patch (application/x-patch, attachment)]

Message #8 received at 36453 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 36453 <at> debbugs.gnu.org
Subject: Re: bug#36453: [PATCH] Delegate to rectangle version in delim-col
 when appropriate
Date: Tue, 09 Jul 2019 00:52:57 +0200

Stefan Kangas <stefan <at> marxist.se> writes:

> +  (if rectangle-mark-mode
> +      ;; Delegate to delimit-columns-rectangle when called with a
> +      ;; rectangular region.
> +      (delimit-columns-rectangle start end)
> +    (let ((delimit-columns-str-before
> +           (delimit-columns-str delimit-columns-str-before))
> +          (delimit-columns-str-separator

I think this looks like it makes sense, so I've applied it to the
trunk.  However, I've used rectangle-mark-mode only in passing, and the
same with delimit-columns, so if anybody who uses these more regularly
object, please revert this patch.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.