GNU bug report logs - #36452
[PATCH] Add tests for bookmark.el

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 36452 <at> debbugs.gnu.org
Subject: bug#36452: [PATCH] Add tests for bookmark.el
Date: Tue, 02 Jul 2019 19:41:00 +0300

> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Mon, 1 Jul 2019 01:32:56 +0200
> 
> I've written tests for bookmark.el.  Please see the attached patch.

Thanks.  Can you tell the approximate coverage of bookmark
functionality by these tests?

One particular aspect of the bookmarks that I'd like to see tested is
non-ASCII bookmark names and annotations.  The code includes some
slightly involved logic for determining how to encode the info on
disk, so I wonder how well does that work in practice.

> --- /dev/null
> +++ b/test/lisp/bookmark-resources/test.bmk
> @@ -0,0 +1,10 @@
> +;;;; Emacs Bookmark Format Version 1 ;;;; -*- coding: utf-8-emacs -*-
> +;;; This format is meant to be slightly human-readable;
> +;;; nevertheless, you probably don't want to edit it.
> +;;; -*- End Of Bookmark File Format Version Stamp -*-
> +(("name"
> + (filename . "/some/file")
> + (front-context-string . "abc")
> + (rear-context-string . "def")
> + (position . 3))
> +)
> \ No newline at end of file

Is this lack of newline intentional?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.