GNU bug report logs - #36429
[PATCH] profiles: Adjust packages->manifest pattern for inferior packages.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Kyle Meyer <kyle <at> kyleam.com>
Subject: bug#36429: closed (Re: [bug#36429] [PATCH] profiles: Adjust
 packages->manifest pattern for inferior packages.)
Date: Wed, 03 Jul 2019 09:17:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#36429: [PATCH] profiles: Adjust packages->manifest pattern for inferior packages.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 36429 <at> debbugs.gnu.org.

-- 
36429: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36429
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Kyle Meyer <kyle <at> kyleam.com>
Cc: 36429-done <at> debbugs.gnu.org
Subject: Re: [bug#36429] [PATCH] profiles: Adjust packages->manifest pattern
 for inferior packages.
Date: Wed, 03 Jul 2019 11:16:36 +0200

Hello Kyle,

Kyle Meyer <kyle <at> kyleam.com> skribis:

> * guix/profiles.scm (packages->manifest): Add package? predicate to `(package
> output)' pattern to avoid incorrectly matching `(inferior-package output)',
> which should be handled by a later clause.

Good catch.  Applied, thanks!

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Kyle Meyer <kyle <at> kyleam.com>
To: guix-patches <at> gnu.org
Cc: Kyle Meyer <kyle <at> kyleam.com>
Subject: [PATCH] profiles: Adjust packages->manifest pattern for inferior
 packages.
Date: Sat, 29 Jun 2019 01:50:15 -0400

* guix/profiles.scm (packages->manifest): Add package? predicate to `(package
output)' pattern to avoid incorrectly matching `(inferior-package output)',
which should be handled by a later clause.
---
 guix/profiles.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/guix/profiles.scm b/guix/profiles.scm
index dfc9ba1ca0..f5c863945c 100644
--- a/guix/profiles.scm
+++ b/guix/profiles.scm
@@ -8,6 +8,7 @@
 ;;; Copyright © 2016 Chris Marusich <cmmarusich <at> gmail.com>
 ;;; Copyright © 2017 Huang Ying <huang.ying.caritas <at> gmail.com>
 ;;; Copyright © 2017 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
+;;; Copyright © 2019 Kyle Meyer <kyle <at> kyleam.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -337,7 +338,7 @@ (define (packages->manifest packages)
 
   (manifest
    (map (match-lambda
-          ((package output)
+          (((? package? package) output)
            (package->manifest-entry package output))
           ((? package? package)
            (package->manifest-entry package))
-- 
2.22.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.