GNU bug report logs - #36428
Non-necessary progn afer with-eval-after-load in tramp in recent change

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36428 in the body.
You can then email your comments to 36428 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Shuguang Sun" <shuguang79 <at> qq.com>
To: "bug-gnu-emacs" <bug-gnu-emacs <at> gnu.org>
Subject: Non-necessary progn afer with-eval-after-load in tramp in recent
 change
Date: Sat, 29 Jun 2019 11:49:56 +0800

[Message part 1 (text/plain, inline)]

Hi,


In some recent changes to tramp, the 'eval-after-load' was replaced by 'with-eval-after-load', 

however, the unnecessary 'progn' function for the 'eval-after-load' is no removed.




Best Regards,
Shuguang Sun

[Message part 2 (text/html, inline)]

[tramp_progn_after_with-eval-after-load.diff (application/octet-stream, attachment)]

Message #8 received at 36428 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: "Shuguang Sun" <shuguang79 <at> qq.com>
Cc: 36428 <at> debbugs.gnu.org
Subject: Re: bug#36428: Non-necessary progn afer with-eval-after-load in tramp
 in recent change
Date: Sat, 29 Jun 2019 10:36:41 +0200

"Shuguang Sun" <shuguang79 <at> qq.com> writes:

> Hi,

Hi,

> In some recent changes to tramp, the 'eval-after-load' was replaced by
> 'with-eval-after-load',
> however, the unnecessary 'progn' function for the 'eval-after-load' is
> no removed.

Thanks, this was an overrsight by me. I'm willing to apply your patch,
but it changes 47 lines; too much for a tiny patch.

However, the real change touches just 10 lines, everything else are just
indentation (white space) changes. So IMHO, the patch could be applied
w/o signed papers.

Eli?

> Best Regards,
> Shuguang Sun

Best regards, Michael.

Message #15 received at 36428 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 36428 <at> debbugs.gnu.org, shuguang79 <at> qq.com
Subject: Re: bug#36428: Non-necessary progn afer with-eval-after-load in tramp
 in recent change
Date: Sat, 29 Jun 2019 12:55:19 +0300

> From: Michael Albinus <michael.albinus <at> gmx.de>
> Date: Sat, 29 Jun 2019 10:36:41 +0200
> Cc: 36428 <at> debbugs.gnu.org
> 
> > In some recent changes to tramp, the 'eval-after-load' was replaced by
> > 'with-eval-after-load',
> > however, the unnecessary 'progn' function for the 'eval-after-load' is
> > no removed.
> 
> Thanks, this was an overrsight by me. I'm willing to apply your patch,
> but it changes 47 lines; too much for a tiny patch.
> 
> However, the real change touches just 10 lines, everything else are just
> indentation (white space) changes. So IMHO, the patch could be applied
> w/o signed papers.
> 
> Eli?

Yes, this needs no legal paperwork.

Thanks.

Message #20 received at 36428-done <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 36428-done <at> debbugs.gnu.org, shuguang79 <at> qq.com
Subject: Re: bug#36428: Non-necessary progn afer with-eval-after-load in tramp
 in recent change
Date: Sat, 29 Jun 2019 12:23:16 +0200

Version: 27.1

Eli Zaretskii <eliz <at> gnu.org> writes:

>> However, the real change touches just 10 lines, everything else are just
>> indentation (white space) changes. So IMHO, the patch could be applied
>> w/o signed papers.
>>
>> Eli?
>
> Yes, this needs no legal paperwork.

Thanks, I've pushed it to master. Closing the bug.

> Thanks.

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.