GNU bug report logs - #36428
Non-necessary progn afer with-eval-after-load in tramp in recent change

Previous Next

Full log

View this message in rfc822 format

From: Michael Albinus <michael.albinus <at> gmx.de>
To: "Shuguang Sun" <shuguang79 <at> qq.com>
Cc: 36428 <at> debbugs.gnu.org
Subject: bug#36428: Non-necessary progn afer with-eval-after-load in tramp in recent change
Date: Sat, 29 Jun 2019 10:36:41 +0200

"Shuguang Sun" <shuguang79 <at> qq.com> writes:

> Hi,

Hi,

> In some recent changes to tramp, the 'eval-after-load' was replaced by
> 'with-eval-after-load',
> however, the unnecessary 'progn' function for the 'eval-after-load' is
> no removed.

Thanks, this was an overrsight by me. I'm willing to apply your patch,
but it changes 47 lines; too much for a tiny patch.

However, the real change touches just 10 lines, everything else are just
indentation (white space) changes. So IMHO, the patch could be applied
w/o signed papers.

Eli?

> Best Regards,
> Shuguang Sun

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.