GNU bug report logs - #36428
Non-necessary progn afer with-eval-after-load in tramp in recent change

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: "Shuguang Sun" <shuguang79 <at> qq.com>
Subject: bug#36428: closed (Re: bug#36428: Non-necessary progn afer
 with-eval-after-load in tramp in recent change)
Date: Sat, 29 Jun 2019 10:29:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#36428: Non-necessary progn afer with-eval-after-load in tramp in recent change

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 36428 <at> debbugs.gnu.org.

-- 
36428: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36428
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 36428-done <at> debbugs.gnu.org, shuguang79 <at> qq.com
Subject: Re: bug#36428: Non-necessary progn afer with-eval-after-load in tramp
 in recent change
Date: Sat, 29 Jun 2019 12:23:16 +0200

Version: 27.1

Eli Zaretskii <eliz <at> gnu.org> writes:

>> However, the real change touches just 10 lines, everything else are just
>> indentation (white space) changes. So IMHO, the patch could be applied
>> w/o signed papers.
>>
>> Eli?
>
> Yes, this needs no legal paperwork.

Thanks, I've pushed it to master. Closing the bug.

> Thanks.

Best regards, Michael.

[Message part 3 (message/rfc822, inline)]

From: "Shuguang Sun" <shuguang79 <at> qq.com>
To: "bug-gnu-emacs" <bug-gnu-emacs <at> gnu.org>
Subject: Non-necessary progn afer with-eval-after-load in tramp in recent
 change
Date: Sat, 29 Jun 2019 11:49:56 +0800

[Message part 4 (text/plain, inline)]

Hi,


In some recent changes to tramp, the 'eval-after-load' was replaced by 'with-eval-after-load', 

however, the unnecessary 'progn' function for the 'eval-after-load' is no removed.




Best Regards,
Shuguang Sun

[Message part 5 (text/html, inline)]

[tramp_progn_after_with-eval-after-load.diff (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.