GNU bug report logs - #36428
Non-necessary progn afer with-eval-after-load in tramp in recent change

Previous Next

Package: emacs;

Reported by: "Shuguang Sun" <shuguang79 <at> qq.com>

Date: Sat, 29 Jun 2019 03:58:01 UTC

Severity: minor

Tags: patch

Fixed in version 27.1

Done: Michael Albinus <michael.albinus <at> gmx.de>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 36428 <at> debbugs.gnu.org, shuguang79 <at> qq.com
Subject: bug#36428: Non-necessary progn afer with-eval-after-load in tramp in recent change
Date: Sat, 29 Jun 2019 12:55:19 +0300
> From: Michael Albinus <michael.albinus <at> gmx.de>
> Date: Sat, 29 Jun 2019 10:36:41 +0200
> Cc: 36428 <at> debbugs.gnu.org
> 
> > In some recent changes to tramp, the 'eval-after-load' was replaced by
> > 'with-eval-after-load',
> > however, the unnecessary 'progn' function for the 'eval-after-load' is
> > no removed.
> 
> Thanks, this was an overrsight by me. I'm willing to apply your patch,
> but it changes 47 lines; too much for a tiny patch.
> 
> However, the real change touches just 10 lines, everything else are just
> indentation (white space) changes. So IMHO, the patch could be applied
> w/o signed papers.
> 
> Eli?

Yes, this needs no legal paperwork.

Thanks.




This bug report was last modified 6 years and 47 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.