GNU bug report logs - #36143
[PATCH] Fix typo in src/keyboard.c

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefan <at> marxist.se>
Subject: bug#36143: closed (Re: bug#36143: [PATCH] Fix typo in src/keyboard.c)
Date: Sun, 09 Jun 2019 06:28:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#36143: [PATCH] Fix typo in src/keyboard.c

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 36143 <at> debbugs.gnu.org.

-- 
36143: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36143
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 36143-done <at> debbugs.gnu.org
Subject: Re: bug#36143: [PATCH] Fix typo in src/keyboard.c
Date: Sun, 09 Jun 2019 09:26:56 +0300

> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Sun, 9 Jun 2019 05:16:28 +0200
> 
> Please see attached patch.

Thanks, I pushed it.

However, it looks like your local settings make Emacs untabify C
sources, so in your patch as posted a TAB was converted into spaces,
unlike the indentation around the line you changed (I fixed that
before committing).  Please in the future be sure to edit the Emacs
sources without such local settings; we only prefer spaces to TABs in
Lisp sources, see .dir-locals.el in the repository.

[Message part 3 (message/rfc822, inline)]

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix typo in src/keyboard.c
Date: Sun, 9 Jun 2019 05:16:28 +0200

[Message part 4 (text/plain, inline)]

Please see attached patch.

Thanks,
Stefan Kangas

[0001-src-keyboard.c-tool_bar_items-Fix-typo.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.