GNU bug report logs - #36143
[PATCH] Fix typo in src/keyboard.c

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36143 in the body.
You can then email your comments to 36143 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix typo in src/keyboard.c
Date: Sun, 9 Jun 2019 05:16:28 +0200

[Message part 1 (text/plain, inline)]

Please see attached patch.

Thanks,
Stefan Kangas

[0001-src-keyboard.c-tool_bar_items-Fix-typo.patch (application/octet-stream, attachment)]

Message #10 received at 36143-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 36143-done <at> debbugs.gnu.org
Subject: Re: bug#36143: [PATCH] Fix typo in src/keyboard.c
Date: Sun, 09 Jun 2019 09:26:56 +0300

> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Sun, 9 Jun 2019 05:16:28 +0200
> 
> Please see attached patch.

Thanks, I pushed it.

However, it looks like your local settings make Emacs untabify C
sources, so in your patch as posted a TAB was converted into spaces,
unlike the indentation around the line you changed (I fixed that
before committing).  Please in the future be sure to edit the Emacs
sources without such local settings; we only prefer spaces to TABs in
Lisp sources, see .dir-locals.el in the repository.

Message #13 received at 36143-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 36143-done <at> debbugs.gnu.org
Subject: Re: bug#36143: [PATCH] Fix typo in src/keyboard.c
Date: Sun, 9 Jun 2019 10:00:41 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:
> Thanks, I pushed it.
>
>  [...] Please in the future be sure to edit the Emacs
> sources without such local settings; we only prefer spaces to TABs in
> Lisp sources, see .dir-locals.el in the repository.

Got it, thank you for taking care of it and installing it.

Best regards,
Stefan Kangas

Message #16 received at 36143 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: 36143 <at> debbugs.gnu.org
Cc: , Stefan Kangas <stefan <at> marxist.se>
Subject: Re: bug#36143: [PATCH] Fix typo in src/keyboard.c)
Date: Sun, 09 Jun 2019 09:20:52 -0400

> However, it looks like your local settings make Emacs untabify C
> sources, so in your patch as posted a TAB was converted into spaces,
> unlike the indentation around the line you changed (I fixed that
> before committing).  Please in the future be sure to edit the Emacs
> sources without such local settings; we only prefer spaces to TABs in
> Lisp sources, see .dir-locals.el in the repository.

Oh, I also didn't realize C sources were supposed to be TABified.  Maybe
.dir-locals.el should have an explicit (indent-tabs-mode . t) setting
under c-mode?  Especially since with GNU indent style,
indent-tabs-mode=t results in a file which mixes tabs and spaces, so
it's not obvious that the tabs are really intentional.

Message #19 received at 36143 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: , stefan <at> marxist.se, 36143 <at> debbugs.gnu.org
Subject: Re: bug#36143: [PATCH] Fix typo in src/keyboard.c)
Date: Sun, 09 Jun 2019 16:56:41 +0300

> From: Noam Postavsky <npostavs <at> gmail.com>
> Date: Sun, 09 Jun 2019 09:20:52 -0400
> Cc: , Stefan Kangas <stefan <at> marxist.se>
> 
> Oh, I also didn't realize C sources were supposed to be TABified.  Maybe
> .dir-locals.el should have an explicit (indent-tabs-mode . t) setting
> under c-mode?

It'd be fine with me, but maybe others will object.

I think it's okay to indent new C code with spaces, but when a few
lines are modified in an otherwise TAB-indented block, that makes the
source unaligned when reindented, so IMO should be avoided.  And in
this case, it was even more extreme: a line was modified only very
slightly, so changing whitespace for only that single line was IMO
gross.

Message #22 received at 36143 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 36143 <at> debbugs.gnu.org, stefan <at> marxist.se
Subject: Re: bug#36143: [PATCH] Fix typo in src/keyboard.c)
Date: Sun, 09 Jun 2019 10:07:28 -0400

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Noam Postavsky <npostavs <at> gmail.com>
>> Date: Sun, 09 Jun 2019 09:20:52 -0400
>> Cc: , Stefan Kangas <stefan <at> marxist.se>
>> 
>> Oh, I also didn't realize C sources were supposed to be TABified.  Maybe
>> .dir-locals.el should have an explicit (indent-tabs-mode . t) setting
>> under c-mode?

> I think it's okay to indent new C code with spaces,

Oh, in that case the current .dir-locals.el (i.e., no explicit
indent-tabs-mode setting for c-mode) is okay.  And I don't really want
to open up the TABs vs spaces debate, so let's leave it as is.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.