GNU bug report logs - #36143
[PATCH] Fix typo in src/keyboard.c

Previous Next

Full log

Message #19 received at 36143 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: , stefan <at> marxist.se, 36143 <at> debbugs.gnu.org
Subject: Re: bug#36143: [PATCH] Fix typo in src/keyboard.c)
Date: Sun, 09 Jun 2019 16:56:41 +0300

> From: Noam Postavsky <npostavs <at> gmail.com>
> Date: Sun, 09 Jun 2019 09:20:52 -0400
> Cc: , Stefan Kangas <stefan <at> marxist.se>
> 
> Oh, I also didn't realize C sources were supposed to be TABified.  Maybe
> .dir-locals.el should have an explicit (indent-tabs-mode . t) setting
> under c-mode?

It'd be fine with me, but maybe others will object.

I think it's okay to indent new C code with spaces, but when a few
lines are modified in an otherwise TAB-indented block, that makes the
source unaligned when reindented, so IMO should be avoided.  And in
this case, it was even more extreme: a line was modified only very
slightly, so changing whitespace for only that single line was IMO
gross.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.