GNU bug report logs - #36135
Installer wifi password prompt is not hidden and limited in size

Previous Next

Full log

Message #19 received at 36135 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: Julien Lepiller <julien <at> lepiller.eu>, 36135 <at> debbugs.gnu.org
Subject: Re: bug#36135: installer wifi password prompt
Date: Mon, 10 Jun 2019 23:38:25 +0200

Hi!

Tobias Geerinckx-Rice <me <at> tobias.gr> skribis:

> Ludovic Courtès wrote:
>> Tobias Geerinckx-Rice <me <at> tobias.gr> skribis:
>>
>>> * gnu/installer/newt/wifi.scm (run-wifi-password-page):
>>> Add an #:INPUT-SHOW-CHECKBOX? to the input page.
>>
>> [...]
>>
>>> +                  #:input-show-checkbox? #t))
>>
>> It’s called #:input-hide-checkbox? AFAICS.
>
> Yes.  See the other patches in this ad-hoc ‘series’.

OK.

>> You can double-check that it builds without warnings with:
>>
>>   guix system vm -v2 gnu/system/install.scm
>
> Sure, I guess, but could you explain the point of doing so?
> Reproducibility by others?  I don't think patches like these should be
> pushed with such light testing, and I don't see how this can be tested
> in a VM.

No argument here!  The patch referred to a keyword argument that does
not exist, which is why I’m indeed suggesting more testing.  Simply
looking at the compiler warnings would have raised a flag.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.