GNU bug report logs - #36135
Installer wifi password prompt is not hidden and limited in size

Previous Next

To reply to this bug, email your comments to 36135 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: bug-guix <at> gnu.org
Subject: installer wifi password prompt
Date: Sat, 8 Jun 2019 15:15:02 +0200

Hi,

i just installed a new Guix System and had to use wifi for connecting
to the internet. Unfortunately, I found a few bugs with the wifi screen:

* The wifi screen doesn't automatically scan for wifi network, it would
  be nice if it did it when you first get to that screen.
* The password prompt is not hidden, it's a simple text prompt.
* The password prompt was not large enough for my password, so I was
  unable to connect. I had to use connmanctl from another tty to
  connect.
* Even if already connected (outside of the installer), we still have to
  choose a network. The connected network is marked with a '*' so the
  code should be able to access that information, I think.

Thank you!

Message #8 received at 36135 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 36132 <at> debbugs.gnu.org
Cc: 36135 <at> debbugs.gnu.org
Subject: [PATCH 3/2] installer: Hide the Wi-Fi passphrase by default.
Date: Sat,  8 Jun 2019 17:43:38 +0200

* gnu/installer/newt/wifi.scm (run-wifi-password-page):
Add an #:INPUT-SHOW-CHECKBOX? to the input page.
---

Guix,

This adds a ‘[ ] Show’ checkbox to the newt installer's Wi-Fi passphrase input field, which has also been requested at least twice now.  Most recently here[0].

Kind regards,

T G-R

[0]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=36135

 gnu/installer/newt/wifi.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/installer/newt/wifi.scm b/gnu/installer/newt/wifi.scm
index 1cb2ef2df3..040e013293 100644
--- a/gnu/installer/newt/wifi.scm
+++ b/gnu/installer/newt/wifi.scm
@@ -1,6 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2018 Mathieu Othacehe <m.othacehe <at> gmail.com>
 ;;; Copyright © 2019 Meiyo Peng <meiyo <at> riseup.net>
+;;; Copyright © 2019 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -88,7 +89,8 @@ nmc_wifi_strength_bars."
 (define (run-wifi-password-page)
   "Run a page prompting user for a password and return it."
   (run-input-page (G_ "Please enter the wifi password.")
-                  (G_ "Password required")))
+                  (G_ "Password required")
+                  #:input-show-checkbox? #t))
 
 (define (run-wrong-password-page service-name)
   "Run a page to inform user of a wrong password input."
-- 
2.21.0

Message #11 received at 36135 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 36135 <at> debbugs.gnu.org
Subject: Re: bug#36135: installer wifi password prompt
Date: Sat, 08 Jun 2019 21:42:10 +0200

Hello,

Julien Lepiller <julien <at> lepiller.eu> skribis:

> * The wifi screen doesn't automatically scan for wifi network, it would
>   be nice if it did it when you first get to that screen.
> * The password prompt is not hidden, it's a simple text prompt.
> * The password prompt was not large enough for my password, so I was
>   unable to connect. I had to use connmanctl from another tty to
>   connect.
> * Even if already connected (outside of the installer), we still have to
>   choose a network. The connected network is marked with a '*' so the
>   code should be able to access that information, I think.

Tobias Geerinckx-Rice <me <at> tobias.gr> skribis:

> * gnu/installer/newt/wifi.scm (run-wifi-password-page):
> Add an #:INPUT-SHOW-CHECKBOX? to the input page.

[...]

> +                  #:input-show-checkbox? #t))

It’s called #:input-hide-checkbox? AFAICS.

You can double-check that it builds without warnings with:

  guix system vm -v2 gnu/system/install.scm

Please add a “Partly fixes …” line.  This fixes both the password length
and the password visibility issues since ‘run-input-page’ will now use
FLAG-SCROLL.

Thanks!

Ludo’.

Message #16 received at 36135 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Julien Lepiller <julien <at> lepiller.eu>, 36135 <at> debbugs.gnu.org
Subject: Re: bug#36135: installer wifi password prompt
Date: Sat, 08 Jun 2019 22:11:08 +0200

[Message part 1 (text/plain, inline)]

Ludo',

Ludovic Courtès wrote:
> Tobias Geerinckx-Rice <me <at> tobias.gr> skribis:
>
>> * gnu/installer/newt/wifi.scm (run-wifi-password-page):
>> Add an #:INPUT-SHOW-CHECKBOX? to the input page.
>
> [...]
>
>> +                  #:input-show-checkbox? #t))
>
> It’s called #:input-hide-checkbox? AFAICS.

Yes.  See the other patches in this ad-hoc ‘series’.

> You can double-check that it builds without warnings with:
>
>   guix system vm -v2 gnu/system/install.scm

Sure, I guess, but could you explain the point of doing so? 
Reproducibility by others?  I don't think patches like these 
should be pushed with such light testing, and I don't see how this 
can be tested in a VM.

Hence the dusty Dell Latitude mentioned earlier ;-)

It smells funny.

> Please add a “Partly fixes …” line.  This fixes both the 
> password length
> and the password visibility issues since ‘run-input-page’ will 
> now use
> FLAG-SCROLL.

Yah, I didn't merge the bugs for that reason, and because I'm 
still trying to fix more bugs (well, mainly waiting for dd while 
doing other stuff, since this can't be tested in a VM…)

Thanks!

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 36135 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: Julien Lepiller <julien <at> lepiller.eu>, 36135 <at> debbugs.gnu.org
Subject: Re: bug#36135: installer wifi password prompt
Date: Mon, 10 Jun 2019 23:38:25 +0200

Hi!

Tobias Geerinckx-Rice <me <at> tobias.gr> skribis:

> Ludovic Courtès wrote:
>> Tobias Geerinckx-Rice <me <at> tobias.gr> skribis:
>>
>>> * gnu/installer/newt/wifi.scm (run-wifi-password-page):
>>> Add an #:INPUT-SHOW-CHECKBOX? to the input page.
>>
>> [...]
>>
>>> +                  #:input-show-checkbox? #t))
>>
>> It’s called #:input-hide-checkbox? AFAICS.
>
> Yes.  See the other patches in this ad-hoc ‘series’.

OK.

>> You can double-check that it builds without warnings with:
>>
>>   guix system vm -v2 gnu/system/install.scm
>
> Sure, I guess, but could you explain the point of doing so?
> Reproducibility by others?  I don't think patches like these should be
> pushed with such light testing, and I don't see how this can be tested
> in a VM.

No argument here!  The patch referred to a keyword argument that does
not exist, which is why I’m indeed suggesting more testing.  Simply
looking at the compiler warnings would have raised a flag.

Ludo’.

Message #22 received at 36135 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 36135 <at> debbugs.gnu.org
Subject: Re: bug#36135: installer wifi password prompt
Date: Tue, 11 Jun 2019 00:36:55 +0200

[Message part 1 (text/plain, inline)]

Hah,

Ludovic Courtès wrote:
> No argument here!  The patch referred to a keyword argument that 
> does
> not exist, which is why I’m indeed suggesting more testing. 
> Simply
> looking at the compiler warnings would have raised a flag.

There were no warnings and the code itself runs fine (believe me, 
I've run it way too often already -_-') because this was written 
on top of #36132.

I guess I was optimistic about its speedy acceptance.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 36135 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 36135 <at> debbugs.gnu.org
Subject: Re: bug#36135: installer wifi password prompt
Date: Wed, 12 Jun 2019 11:30:11 +0200

Hi Tobias,

Tobias Geerinckx-Rice <me <at> tobias.gr> skribis:

> Ludovic Courtès wrote:
>> No argument here!  The patch referred to a keyword argument that
>> does
>> not exist, which is why I’m indeed suggesting more testing. Simply
>> looking at the compiler warnings would have raised a flag.
>
> There were no warnings and the code itself runs fine (believe me, I've
> run it way too often already -_-') because this was written on top of
> #36132.

Oh, my bad!  I hadn’t seen <https://issues.guix.gnu.org/issue/36132>.

I’ll take a look.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.