GNU bug report logs - #35880
[PATCH 0/7] Lzip support for 'guix publish' and 'guix substitute'

Previous Next

Package: guix-patches;

Reported by: Ludovic Courtès <ludo <at> gnu.org>

Date: Fri, 24 May 2019 13:34:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: Ludovic Courtès <ludo <at> gnu.org>, 35880 <at> debbugs.gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: [bug#35880] [PATCH 3/7] utils: Support compression and decompression with lzip.
Date: Sat, 25 May 2019 19:27:19 +0200
[Message part 1 (text/plain, inline)]
This is the part where you use make-lzip-input-port/compressed:

>  (define (compressed-port compression input)
> -  "Return an input port where INPUT is decompressed according to COMPRESSION,
> +  "Return an input port where INPUT is compressed according to COMPRESSION,
>  a symbol such as 'xz."
>    (match compression
>      ((or #f 'none) (values input '()))
>      ('bzip2        (filtered-port `(,%bzip2 "-c") input))
>      ('xz           (filtered-port `(,%xz "-c") input))
>      ('gzip         (filtered-port `(,%gzip "-c") input))
> -    (else          (error "unsupported compression scheme" compression))))
> +    ('lzip         (values (lzip-port 'make-lzip-input-port/compressed input)
> +                           '()))
> +    (_             (error "unsupported compression scheme" compression))))

So why not doing like for the others?


-- 
Pierre Neidhardt
https://ambrevar.xyz/
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 5 years and 350 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.