GNU bug report logs - #35879
[PATCH] tests: init: use $PATH_SEPARATOR instead of hard-coded colon(:)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35879 in the body.
You can then email your comments to 35879 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: KO Myung-Hun <komh78 <at> gmail.com>
To: bug-diffutils <at> gnu.org
Subject: [PATCH] tests: init: use $PATH_SEPARATOR instead of hard-coded
 colon(:)
Date: Fri, 24 May 2019 18:38:53 +0900

On OS/2, a path separator is semi-colon(;) not colon(:).

* tests/init.cfg: Replace hard-coded colon(:) with $PATH_SEPARATOR.
---
 tests/init.cfg | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tests/init.cfg b/tests/init.cfg
index d563156..c1f7941 100644
--- a/tests/init.cfg
+++ b/tests/init.cfg
@@ -33,7 +33,7 @@ sanitize_path_()
   # FIXME: remove double quotes around $IFS when all tests use init.sh.
   # They constitute a work-around for a bug in FreeBSD 8.1's /bin/sh.
   local saved_IFS="$IFS"
-    IFS=:
+    IFS=$PATH_SEPARATOR
     set -- $PATH
   IFS=$saved_IFS
 
@@ -44,14 +44,14 @@ sanitize_path_()
     test -z "$d" && d1=. || d1=$d
     if ls -d "$d1/." > /dev/null 2>&1; then
       new_path="$new_path$colon$d"
-      colon=':'
+      colon=$PATH_SEPARATOR
     fi
   done
 
   for d in /sbin /usr/sbin ; do
-    case ":$new_path:" in
-      *:$d:*) ;;
-      *) new_path="$new_path:$d" ;;
+    case "$PATH_SEPARATOR$new_path$PATH_SEPARATOR" in
+      *$PATH_SEPARATOR$d$PATH_SEPARATOR*) ;;
+      *) new_path="$new_path$PATH_SEPARATOR$d" ;;
     esac
   done
 
-- 
2.13.3

Message #10 received at 35879-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: KO Myung-Hun <komh78 <at> gmail.com>
Cc: 35879-done <at> debbugs.gnu.org
Subject: Re: [bug-diffutils] bug#35879: [PATCH] tests: init: use
 $PATH_SEPARATOR instead of hard-coded colon(:)
Date: Fri, 24 May 2019 13:38:16 -0700

Thanks, I installed that. You might consider attaching git-format 
patches instead of sending them directly, as gmail seems to be altering 
the "From:" line.

Message #13 received at 35879-done <at> debbugs.gnu.org (full text, mbox):

From: KO Myung-Hun <komh78 <at> gmail.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 35879-done <at> debbugs.gnu.org
Subject: Re: [bug-diffutils] bug#35879: [PATCH] tests: init: use
 $PATH_SEPARATOR instead of hard-coded colon(:)
Date: Sat, 25 May 2019 12:03:53 +0900

Hi/2.

Paul Eggert wrote:
> Thanks, I installed that. You might consider attaching git-format
> patches instead of sending them directly, as gmail seems to be altering
> the "From:" line.

Ok, I got it.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.os2.kr/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.