GNU bug report logs - #35879
[PATCH] tests: init: use $PATH_SEPARATOR instead of hard-coded colon(:)

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#35879: closed ([PATCH] tests: init: use $PATH_SEPARATOR
 instead of hard-coded colon(:))
Date: Fri, 24 May 2019 20:39:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 24 May 2019 13:38:16 -0700
with message-id <45038023-9602-efd5-2cbd-5a39cc3c3b25 <at> cs.ucla.edu>
and subject line Re: [bug-diffutils] bug#35879: [PATCH] tests: init: use $PATH_SEPARATOR instead of hard-coded colon(:)
has caused the debbugs.gnu.org bug report #35879,
regarding [PATCH] tests: init: use $PATH_SEPARATOR instead of hard-coded colon(:)
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
35879: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35879
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: KO Myung-Hun <komh78 <at> gmail.com>
To: bug-diffutils <at> gnu.org
Subject: [PATCH] tests: init: use $PATH_SEPARATOR instead of hard-coded
 colon(:)
Date: Fri, 24 May 2019 18:38:53 +0900

On OS/2, a path separator is semi-colon(;) not colon(:).

* tests/init.cfg: Replace hard-coded colon(:) with $PATH_SEPARATOR.
---
 tests/init.cfg | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tests/init.cfg b/tests/init.cfg
index d563156..c1f7941 100644
--- a/tests/init.cfg
+++ b/tests/init.cfg
@@ -33,7 +33,7 @@ sanitize_path_()
   # FIXME: remove double quotes around $IFS when all tests use init.sh.
   # They constitute a work-around for a bug in FreeBSD 8.1's /bin/sh.
   local saved_IFS="$IFS"
-    IFS=:
+    IFS=$PATH_SEPARATOR
     set -- $PATH
   IFS=$saved_IFS
 
@@ -44,14 +44,14 @@ sanitize_path_()
     test -z "$d" && d1=. || d1=$d
     if ls -d "$d1/." > /dev/null 2>&1; then
       new_path="$new_path$colon$d"
-      colon=':'
+      colon=$PATH_SEPARATOR
     fi
   done
 
   for d in /sbin /usr/sbin ; do
-    case ":$new_path:" in
-      *:$d:*) ;;
-      *) new_path="$new_path:$d" ;;
+    case "$PATH_SEPARATOR$new_path$PATH_SEPARATOR" in
+      *$PATH_SEPARATOR$d$PATH_SEPARATOR*) ;;
+      *) new_path="$new_path$PATH_SEPARATOR$d" ;;
     esac
   done
 
-- 
2.13.3

[Message part 3 (message/rfc822, inline)]

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: KO Myung-Hun <komh78 <at> gmail.com>
Cc: 35879-done <at> debbugs.gnu.org
Subject: Re: [bug-diffutils] bug#35879: [PATCH] tests: init: use
 $PATH_SEPARATOR instead of hard-coded colon(:)
Date: Fri, 24 May 2019 13:38:16 -0700

Thanks, I installed that. You might consider attaching git-format 
patches instead of sending them directly, as gmail seems to be altering 
the "From:" line.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.