GNU bug report logs - #35879
[PATCH] tests: init: use $PATH_SEPARATOR instead of hard-coded colon(:)

Previous Next

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: KO Myung-Hun <komh78 <at> gmail.com>
To: bug-diffutils <at> gnu.org
Subject: [PATCH] tests: init: use $PATH_SEPARATOR instead of hard-coded
 colon(:)
Date: Fri, 24 May 2019 18:38:53 +0900

On OS/2, a path separator is semi-colon(;) not colon(:).

* tests/init.cfg: Replace hard-coded colon(:) with $PATH_SEPARATOR.
---
 tests/init.cfg | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tests/init.cfg b/tests/init.cfg
index d563156..c1f7941 100644
--- a/tests/init.cfg
+++ b/tests/init.cfg
@@ -33,7 +33,7 @@ sanitize_path_()
   # FIXME: remove double quotes around $IFS when all tests use init.sh.
   # They constitute a work-around for a bug in FreeBSD 8.1's /bin/sh.
   local saved_IFS="$IFS"
-    IFS=:
+    IFS=$PATH_SEPARATOR
     set -- $PATH
   IFS=$saved_IFS
 
@@ -44,14 +44,14 @@ sanitize_path_()
     test -z "$d" && d1=. || d1=$d
     if ls -d "$d1/." > /dev/null 2>&1; then
       new_path="$new_path$colon$d"
-      colon=':'
+      colon=$PATH_SEPARATOR
     fi
   done
 
   for d in /sbin /usr/sbin ; do
-    case ":$new_path:" in
-      *:$d:*) ;;
-      *) new_path="$new_path:$d" ;;
+    case "$PATH_SEPARATOR$new_path$PATH_SEPARATOR" in
+      *$PATH_SEPARATOR$d$PATH_SEPARATOR*) ;;
+      *) new_path="$new_path$PATH_SEPARATOR$d" ;;
     esac
   done
 
-- 
2.13.3

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.