GNU bug report logs - #35771
[PATCH] Customization type of recentf-max-saved-items

Previous Next

Full log

Message #40 received at 35771 <at> debbugs.gnu.org (full text, mbox):

From: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 35771 <at> debbugs.gnu.org
Subject: Re: bug#35771: [PATCH] Customization type of recentf-max-saved-items
Date: Sun, 19 May 2019 11:15:24 +0200

[Message part 1 (text/plain, inline)]

"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> (I'm curious as to why :value is set to 1 rather than the default values
> 20 and 400 of the user options recentf-max-saved-items and
> save-place-limit, respectively.  Not an important issue, though.)

I was also wondering the same thing.

> See the outlines "Commit messages" and "Generating ChangeLog entries"
> in the file CONTRIBUTE for the preferred commit message format.
> In particular, it should mention the names of the file and variable
> changed, as well as the bug#number.

Thanks.  I am attaching a patch file with a properly formatted commit
message.

[0001-Customization-type-of-recentf-max-saved-items.patch (text/x-diff, inline)]

From 46a0d4715ce49aee376a4d253a129c5d6b5b97a8 Mon Sep 17 00:00:00 2001
From: Dario Gjorgjevski <dario.gjorgjevski+git <at> gmail.com>
Date: Fri, 17 May 2019 11:46:54 +0200
Subject: [PATCH] Customization type of recentf-max-saved-items

Change the customization type of recentf-max-saved-items to include
nil, as it is an allowed value (Bug#35771).
* lisp/recentf.el (recentf-max-saved-items): Change the customization
type in the defcustom.
---
 lisp/recentf.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/recentf.el b/lisp/recentf.el
index 9b70017a38..4112b44e48 100644
--- a/lisp/recentf.el
+++ b/lisp/recentf.el
@@ -67,7 +67,8 @@ You should define the options of your own filters in this group."
 A nil value means to save the whole list.
 See the command `recentf-save-list'."
   :group 'recentf
-  :type 'integer)
+  :type '(choice (integer :tag "Entries" :value 1)
+		 (const :tag "No Limit" nil)))
 
 (defcustom recentf-save-file (locate-user-emacs-file "recentf" ".recentf")
   "File to save the recent list into."
-- 
2.20.1

[Message part 3 (text/plain, inline)]

-- 
Dario Gjorgjevski :: dario.gjorgjevski <at> gmail.com :: +389 (0)70 784 142

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.