GNU bug report logs - #35772
27.0.50; Repeated define-key call in picture.el

Previous Next

Package: emacs;

Reported by: Mauro Aranda <maurooaranda <at> gmail.com>

Date: Fri, 17 May 2019 13:06:01 UTC

Severity: normal

Tags: fixed

Found in version 27.0.50

Fixed in version 26.3

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35772 in the body.
You can then email your comments to 35772 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#35772; Package emacs. (Fri, 17 May 2019 13:06:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Mauro Aranda <maurooaranda <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 17 May 2019 13:06:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: 27.0.50; Repeated define-key call in picture.el
Date: Fri, 17 May 2019 10:04:32 -0300

[Message part 1 (text/plain, inline)]
Hello.

In picture.el (picture-mode-map), there is a repeated call to
define-key, like this:
(define-key map [remap self-insert-command] 'picture-self-insert)
(define-key map [remap self-insert-command] 'picture-self-insert)

Trivial patch to come.

Best regards,
Mauro.

[Message part 2 (text/html, inline)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#35772; Package emacs. (Fri, 17 May 2019 13:14:02 GMT) Full text and rfc822 format available.

Message #8 received at 35772 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: 35772 <at> debbugs.gnu.org
Subject: Re: bug#35772: 27.0.50; Repeated define-key call in picture.el
Date: Fri, 17 May 2019 10:13:11 -0300

[Message part 1 (text/plain, inline)]
Tags: patch

Patch attached.

[Message part 2 (text/html, inline)]
[0001-Remove-repeated-function-call-in-picture.el.patch (text/x-patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#35772; Package emacs. (Mon, 20 May 2019 18:26:02 GMT) Full text and rfc822 format available.

Message #11 received at 35772 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: 35772 <at> debbugs.gnu.org
Subject: Re: bug#35772: 27.0.50; Repeated define-key call in picture.el
Date: Mon, 20 May 2019 14:25:49 -0400

tags 35772 fixed
close 35772 26.3
quit

Mauro Aranda <maurooaranda <at> gmail.com> writes:

> --- a/lisp/textmodes/picture.el
> +++ b/lisp/textmodes/picture.el
> @@ -625,7 +625,6 @@ 'picture-delete-char
>  (defvar picture-mode-map
>    (let ((map (make-keymap)))
>      (define-key map [remap self-insert-command] 'picture-self-insert)
> -    (define-key map [remap self-insert-command] 'picture-self-insert)

Pushed to emacs-26.

eadf044e06 2019-05-20T14:22:58-04:00 "Remove repeated function call in picture.el"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=eadf044e0663703af61967c1ff890043f46c9a15
Added tag(s) fixed. Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Mon, 20 May 2019 18:26:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 26.3, send any further explanations to 35772 <at> debbugs.gnu.org and Mauro Aranda <maurooaranda <at> gmail.com> Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Mon, 20 May 2019 18:26:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 18 Jun 2019 11:24:06 GMT) Full text and rfc822 format available.
This bug report was last modified 6 years and 84 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.