GNU bug report logs - #35771
[PATCH] Customization type of recentf-max-saved-items

Previous Next

Package: emacs;

Reported by: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>

Date: Fri, 17 May 2019 12:34:01 UTC

Severity: minor

Tags: fixed, patch

Fixed in version 26.3

Done: "Basil L. Contovounesios" <contovob <at> tcd.ie>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
To: 35771 <at> debbugs.gnu.org
Subject: bug#35771: [PATCH] Customization type of recentf-max-saved-items
Date: Fri, 17 May 2019 14:22:02 +0200
[Message part 1 (text/plain, inline)]
The customization type of recentf-max-saved-items is currently defined
as integer, which does not include nil in its domain.  However, setting
this variable to nil is supported in the code and also documented.

This patch changes the customization type to explicitly allow for the
variable to be set to nil through the Customization interface and
similar.  (Please note that I copied the type from save-place-limit in
order to be consistent.)

[0001-Customization-type-of-recentf-max-saved-items.patch (text/x-diff, inline)]
From a62b4c6208f9d64bc49499855e65ae9b9a55b01e Mon Sep 17 00:00:00 2001
From: Dario Gjorgjevski <dario.gjorgjevski+git <at> gmail.com>
Date: Fri, 17 May 2019 11:46:54 +0200
Subject: [PATCH] Customization type of recentf-max-saved-items

---
 lisp/recentf.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/recentf.el b/lisp/recentf.el
index 9b70017a38..4112b44e48 100644
--- a/lisp/recentf.el
+++ b/lisp/recentf.el
@@ -67,7 +67,8 @@ You should define the options of your own filters in this group."
 A nil value means to save the whole list.
 See the command `recentf-save-list'."
   :group 'recentf
-  :type 'integer)
+  :type '(choice (integer :tag "Entries" :value 1)
+		 (const :tag "No Limit" nil)))
 
 (defcustom recentf-save-file (locate-user-emacs-file "recentf" ".recentf")
   "File to save the recent list into."
-- 
2.20.1

[Message part 3 (text/plain, inline)]
-- 
Dario Gjorgjevski :: dario.gjorgjevski <at> gmail.com :: +389 (0)70 784 142

This bug report was last modified 6 years and 82 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.