GNU bug report logs - #35689
Customizable char-fold

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: 35689 <at> debbugs.gnu.org, npostavs <at> gmail.com, juri <at> linkov.net
Subject: bug#35689: Customizable char-fold
Date: Tue, 14 May 2019 09:37:14 +0300

On May 14, 2019 1:18:18 AM GMT+03:00, Noam Postavsky <npostavs <at> gmail.com> wrote:
> Juri Linkov <juri <at> linkov.net> writes:
> 
> > Oh, right.  Do you see a problem with a better patch:
> 
> > +(eval-and-compile (defcustom char-fold-include-base nil
> > +  "Include mappings from composite character to base letter."
> > +  :type 'boolean
> > +  :set (lambda (sym val)
> > +         (set sym val)
> > +         (when (boundp 'char-fold-table)
> > +           (setq char-fold-table (char-fold-make-table))))
> 
> Looks like it could work (though I haven't tested).  The docstrings
> are
> too terse for me easily follow, and they should probably include
> something along the lines of "Setting this variable directly does not
> take effect; either use M-x customize or ..."

We don't gave defcustoms inside eval-and/when-compile anywhere else.  Do we really need this?  For starters, it would defeat cus-dep.el, I think.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.