GNU bug report logs - #35418
[PATCH] Don't poll auto-revert files that use notification

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mattias Engdegård <mattiase <at> acm.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#35418: closed ([PATCH] Don't poll auto-revert files that use
 notification)
Date: Mon, 20 May 2019 19:20:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 20 May 2019 21:19:37 +0200
with message-id <F5BD3994-BF2C-409E-9828-2583C0FC6A45 <at> acm.org>
and subject line Re: bug#35418: [PATCH] Don't poll auto-revert files that use notification
has caused the debbugs.gnu.org bug report #35418,
regarding [PATCH] Don't poll auto-revert files that use notification
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
35418: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35418
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Mattias Engdegård <mattiase <at> acm.org>
To: bug-gnu-emacs <at> gnu.org
Cc: Michael Albinus <michael.albinus <at> gmx.de>
Subject: [PATCH] Don't poll auto-revert files that use notification
Date: Wed, 24 Apr 2019 20:14:46 +0200

[Message part 3 (text/plain, inline)]

It is a waste of power, on battery-powered devices in particular, to poll files in auto-revert mode periodically when change notification is used. The change is straightforward (attached patch); the main concern is whether the notification system is reliable enough.

In general, it probably is. There is a comment in w32notify.c about SMB-mounted file systems from Samba servers; while Samba does support notification nowadays, there are probably older systems still be deficient in that regard. However, isn't this what `auto-revert-notify-exclude-dir-regexp' is for? I'm not familiar with the way Emacs is used on Windows, but would adding something like

 (rx bos
     (or "\\\\" "//")
     (one-or-more (not (any "/:\\")))
     (any "/\\"))

to `auto-revert-notify-exclude-dir-regexp' be a good start?

Another note about what this patch does not do: global-auto-revert-mode will still use polling. This could be added later on, if there is a good place to hook into for buffer creation.

[0001-Don-t-poll-auto-revert-files-that-use-notification.patch (application/octet-stream, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Mattias Engdegård <mattiase <at> acm.org>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 35418-done <at> debbugs.gnu.org
Subject: Re: bug#35418: [PATCH] Don't poll auto-revert files that use
 notification
Date: Mon, 20 May 2019 21:19:37 +0200

20 maj 2019 kl. 09.30 skrev Michael Albinus <michael.albinus <at> gmx.de>:
> 
> From my POV, the patch is fine, and could be committed. Whether it is
> successful will be told us by emba.gnu.org (and hydra.nixos.org).

Thanks for your diligence and patience; closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.