GNU bug report logs - #35381
26.2; nxml-mode doesn't fontify attributes in single quotes

Previous Next

Package: emacs;

Reported by: Noam Postavsky <npostavs <at> gmail.com>

Date: Mon, 22 Apr 2019 16:10:01 UTC

Severity: normal

Tags: confirmed, fixed, patch

Merged with 8203

Found in versions 24.5, 25.0.94, 26.2

Fixed in version 26.3

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #17 received at 35381 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: 35381 <at> debbugs.gnu.org
Subject: Re: bug#35381: 26.2;
 nxml-mode doesn't fontify attributes in single quotes
Date: Wed, 24 Apr 2019 22:24:57 -0400
Stefan Monnier <monnier <at> IRO.UMontreal.CA> writes:

>> +(defvar sgml-specials '(?\" ?\')
>>    "List of characters that have a special meaning for SGML mode.
>>  This list is used when first loading the `sgml-mode' library.
>>  The supported characters and potential disadvantages are:
>
> I think this "disadvantages" part of the docstring is out of date.
> Can you update it while you're at it?
>
> Also, we probably want to mark this var as obsolete.

I'm not sure about this, is the disadvantage of the ?- also out of date?
There's some FIXME on the "--" rule of sgml-syntax-propertize-rules,
 
-;; As long as Emacs's syntax can't be complemented with predicates to context
-;; sensitively confirm the syntax of characters, we have to live with this
-;; kludgy kind of tradeoff.
 (defvar sgml-specials '(?\" ?\')
   "List of characters that have a special meaning for SGML mode.
 This list is used when first loading the `sgml-mode' library.
-The supported characters and potential disadvantages are:
-
-  ?\\\"	Makes \" in text start a string.
-  ?\\='	Makes \\=' in text start a string.
-  ?-	Makes -- in text start a comment.
-
-When only one of ?\\\" or ?\\=' are included, \"\\='\" or \\='\"\\=', as can be found in
-DTDs, start a string.  To partially avoid this problem this also makes these
-self insert as named entities depending on `sgml-quick-keys'.
+The supported characters are ?\\\", ?\\=', and ?-.
 
 Including ?- has the problem of affecting dashes that have nothing to do
 with comments, so we normally turn it off.")





This bug report was last modified 6 years and 13 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.