GNU bug report logs - #35346
[PATCH 0/2] Add pass-otp

Previous Next

Full log

Message #21 received at 35346 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Alex Griffin <a <at> ajgrf.com>
Cc: 35346 <at> debbugs.gnu.org
Subject: Re: [bug#35346] [PATCH 2/2] gnu: Add pass-otp.
Date: Sun, 21 Apr 2019 22:30:45 +0100

[Message part 1 (text/plain, inline)]

Alex Griffin <a <at> ajgrf.com> writes:

> * gnu/packages/password-utils.scm (pass-otp): New variable.
>

...

> +(define-public pass-otp
> +  (package
> +    (name "pass-otp")
> +    (version "1.2.0")

...

> +    (native-search-paths
> +     (list (search-path-specification
> +            (variable "PASSWORD_STORE_SYSTEM_EXTENSION_DIR")
> +            (files '("lib/password-store/extensions")))))

Hi Alex,

These changes are looking good, one thing though, is that I think this
native-search-paths field should be defined for the password-store
package, as it's the one that uses the search path.

While it works having it defined for pass-otp, having it in the
password-store package will become relevant if there are more extensions
packaged for Guix, as then they'll be able to take advantage of this as
well.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.