GNU bug report logs - #35346
[PATCH 0/2] Add pass-otp

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35346 in the body.
You can then email your comments to 35346 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: guix-patches <at> gnu.org
Subject: [0/2] Add pass-otp
Date: Sat, 20 Apr 2019 13:50:45 -0400

This patch series adds a mechanism for providing pass extensions in separate packages, then adds the pass-otp package.

-- 
Alex Griffin

Message #8 received at 35346 <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: 35346 <at> debbugs.gnu.org
Subject: [PATCH 1/2] gnu: password-store: Allow external packages to provide extensions.
Date: Sat, 20 Apr 2019 13:54:52 -0400

[Message part 1 (text/plain, inline)]

* gnu/packages/password-utils.scm (password-store): Add environment variable
PASSWORD_STORE_SYSTEM_EXTENSION_DIR to support pass extensions in external
packages.
[arguments]: Add patch-system-extension-dir phase.

-- 
Alex Griffin

[0001-gnu-password-store-Allow-external-packages-to-provid.patch (text/x-patch, attachment)]

Message #11 received at 35346 <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: 35346 <at> debbugs.gnu.org
Subject: [PATCH 2/2] gnu: Add pass-otp.
Date: Sat, 20 Apr 2019 13:55:57 -0400

[Message part 1 (text/plain, inline)]

* gnu/packages/password-utils.scm (pass-otp): New variable.

-- 
Alex Griffin

[0002-gnu-Add-pass-otp.patch (text/x-patch, attachment)]

Message #16 received at 35346 <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: 35346 <at> debbugs.gnu.org
Subject: Add patch tag to #35346
Date: Sat, 20 Apr 2019 15:59:05 -0400

tags 35346 patch

Message #21 received at 35346 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Alex Griffin <a <at> ajgrf.com>
Cc: 35346 <at> debbugs.gnu.org
Subject: Re: [bug#35346] [PATCH 2/2] gnu: Add pass-otp.
Date: Sun, 21 Apr 2019 22:30:45 +0100

[Message part 1 (text/plain, inline)]

Alex Griffin <a <at> ajgrf.com> writes:

> * gnu/packages/password-utils.scm (pass-otp): New variable.
>

...

> +(define-public pass-otp
> +  (package
> +    (name "pass-otp")
> +    (version "1.2.0")

...

> +    (native-search-paths
> +     (list (search-path-specification
> +            (variable "PASSWORD_STORE_SYSTEM_EXTENSION_DIR")
> +            (files '("lib/password-store/extensions")))))

Hi Alex,

These changes are looking good, one thing though, is that I think this
native-search-paths field should be defined for the password-store
package, as it's the one that uses the search path.

While it works having it defined for pass-otp, having it in the
password-store package will become relevant if there are more extensions
packaged for Guix, as then they'll be able to take advantage of this as
well.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Message #24 received at 35346 <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: "Christopher Baines" <mail <at> cbaines.net>
Cc: 35346 <at> debbugs.gnu.org
Subject: Re: [bug#35346] [PATCH 2/2] gnu: Add pass-otp.
Date: Sun, 21 Apr 2019 20:26:45 -0400

[Message part 1 (text/plain, inline)]

On Sun, Apr 21, 2019, at 9:30 PM, Christopher Baines wrote:
> These changes are looking good, one thing though, is that I think this
> native-search-paths field should be defined for the password-store
> package, as it's the one that uses the search path.
> 
> While it works having it defined for pass-otp, having it in the
> password-store package will become relevant if there are more extensions
> packaged for Guix, as then they'll be able to take advantage of this as
> well.

Thanks Chris, that makes sense. I've attached 2 updated patches with the requested changes.

-- 
Alex Griffin

[0001-gnu-password-store-Allow-external-packages-to-provid.patch (text/x-patch, attachment)]

[0002-gnu-Add-pass-otp.patch (text/x-patch, attachment)]

Message #29 received at 35346-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Alex Griffin <a <at> ajgrf.com>
Cc: 35346-done <at> debbugs.gnu.org
Subject: Re: [bug#35346] [PATCH 2/2] gnu: Add pass-otp.
Date: Mon, 22 Apr 2019 10:36:24 +0100

[Message part 1 (text/plain, inline)]

Alex Griffin <a <at> ajgrf.com> writes:

> On Sun, Apr 21, 2019, at 9:30 PM, Christopher Baines wrote:
>> These changes are looking good, one thing though, is that I think this
>> native-search-paths field should be defined for the password-store
>> package, as it's the one that uses the search path.
>>
>> While it works having it defined for pass-otp, having it in the
>> password-store package will become relevant if there are more extensions
>> packaged for Guix, as then they'll be able to take advantage of this as
>> well.
>
> Thanks Chris, that makes sense. I've attached 2 updated patches with the requested changes.

Great, I've pushed these two patches now, with a few minor changes
that'll describe below.

> From 8f64805def5352919e4dac57ce0adc79f0243a43 Mon Sep 17 00:00:00 2001
> From: Alex Griffin <a <at> ajgrf.com>
> Date: Sat, 20 Apr 2019 11:56:23 -0500
> Subject: [PATCH 1/2] gnu: password-store: Allow external packages to provide
>  extensions.
>
> * gnu/packages/password-utils.scm (password-store): Add mechanism for
> providing pass extensions in separate packages.
> [arguments]: Add patch-system-extension-dir phase.
> [native-search-paths]: Add PASSWORD_STORE_SYSTEM_EXTENSION_DIR.
> ---
>  gnu/packages/password-utils.scm | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
> index 5c11d8c437..5cd8e2f160 100644
> --- a/gnu/packages/password-utils.scm
> +++ b/gnu/packages/password-utils.scm
> @@ -6,7 +6,7 @@
>  ;;; Copyright © 2016 Jessica Tallon <tsyesika <at> tsyesika.se>
>  ;;; Copyright © 2016 Andreas Enge <andreas <at> enge.fr>
>  ;;; Copyright © 2016 Lukas Gradl <lgradl <at> openmailbox.org>
> -;;; Copyright © 2016 Alex Griffin <a <at> ajgrf.com>
> +;;; Copyright © 2016, 2019 Alex Griffin <a <at> ajgrf.com>
>  ;;; Copyright © 2017 Leo Famulari <leo <at> famulari.name>
>  ;;; Copyright © 2017, 2018 Clément Lassieur <clement <at> lassieur.org>
>  ;;; Copyright © 2017, 2018, 2019 Tobias Geerinckx-Rice <me <at> tobias.gr>
> @@ -423,6 +423,18 @@ any X11 window.")
>         (modify-phases %standard-phases
>           (delete 'configure)
>           (delete 'build)
> +         (add-before 'install 'patch-system-extension-dir
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (extension-dir (string-append out "/lib/password-store/extensions")))
> +               (substitute* "src/password-store.sh"
> +                 (("^SYSTEM_EXTENSION_DIR=.*$")
> +                  ;; lead with whitespace to prevent 'make install' from
> +                  ;; overwriting it again
> +                  (string-append " SYSTEM_EXTENSION_DIR=\""
> +                                 "${PASSWORD_STORE_SYSTEM_EXTENSION_DIR:-"
> +                                 extension-dir
> +                                 "}\"\n"))))))

I'm still not quite sure why, but currently it's at least more
consistent if phases like the one above evaluate to #t, so I've added #t
in at the end.

> From 0c695f7ee5151a4c1747591ca165b44c5b9e553b Mon Sep 17 00:00:00 2001
> From: Alex Griffin <a <at> ajgrf.com>
> Date: Sat, 20 Apr 2019 11:59:35 -0500
> Subject: [PATCH 2/2] gnu: Add pass-otp.
>
> * gnu/packages/password-utils.scm (pass-otp): New variable.
> ---
>  gnu/packages/password-utils.scm | 49 +++++++++++++++++++++++++++++++++
>  1 file changed, 49 insertions(+)
>
> diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
> index 5cd8e2f160..fd0a7c6501 100644
> --- a/gnu/packages/password-utils.scm
> +++ b/gnu/packages/password-utils.scm

...

> +    (inputs
> +     `(("password-store" ,password-store)
> +       ("expect" ,expect)
> +       ("oath-toolkit" ,oath-toolkit)
> +       ("git" ,git)
> +       ("gnupg" ,gnupg)
> +       ("which" ,which)))

oath-toolkit is the only one of these inputs referenced by the output,
so I've changed the others in to native-inputs, as I think this makes a
bit more sense.

> +    (home-page "https://github.com/tadfisher/pass-otp")
> +    (synopsis "Pass extension for managing one-time-password (OTP) tokens")
> +    (description " An extension for password-store that allows adding
> +one-time-password (OTP) secrets, generating OTP codes, and displaying secret
> +key URIs using the standard otpauth:// scheme.")

I've tweaked the description slightly, removing the space at the start,
and making it more of a complete sentence:

  "Pass OTP is an extension for password-store that allows ..."

Thanks again,

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.