GNU bug report logs - #35013
speedbar-expand-line-descendants opens non-descendant tree entries

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35013 in the body.
You can then email your comments to 35013 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kieran Barry <kieranb <at> google.com>
To: bug-gnu-emacs <at> gnu.org
Subject: speedbar-expand-line-descendants opens non-descendant tree entries
Date: Tue, 26 Mar 2019 20:28:46 +0000

[Message part 1 (text/plain, inline)]

Current behaviour:
speedbar-expand-line-descendants incorrectly recursively expands all nodes
below the current node.

Expected behaviour:
Should only recursively expand descendants of the current node.

Steps to reproduce:
emacs -Q ~
M-x speedbar
<focus to speedbar>
<cursor over a directory that is not the last in list>
[

("[" is bound to `speedbar-expand-line-descendants')

Found in: GNU Emacs 26.1

-- 
Kieran Barry -- kieranb <at> google.com
EU Directive 2003/58/EC compliance:
Google Ireland Ltd., Gordon House, Barrow Street, Dublin 4 Ireland
Registered in Dublin, Ireland with # 368047

[Message part 2 (text/html, inline)]

Message #12 received at 35013 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Kieran Barry <kieranb <at> google.com>
Cc: 35013 <at> debbugs.gnu.org, 35014 <at> debbugs.gnu.org
Subject: Re: bug#35014: speedbar-expand-line-descendants opens
 non-descendant tree entries
Date: Wed, 19 Aug 2020 12:46:17 +0200

Kieran Barry <kieranb <at> google.com> writes:

> Patch to fix.
>
> Changelog:
> 2019-03-26  Kieran Barry  <kieranb@....com>
> * lisp/speedbar.el: speedbar-expand-line-descendants fixed to only expand
> descendants of current node.

Thanks for the patch.

I had a look at the speedbar code (I don't normally use the mode
myself), and there seemed like a much simpler fix -- just narrow to the
current line before starting to expand.  I tried that, and it seems to
work for me, so I've pushed that fix to Emacs 28 instead.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.