GNU bug report logs - #34526
Updating node from version 10

Previous Next

Package: guix-patches;

Reported by: Daniel Gerber <dg <at> atufi.org>

Date: Mon, 18 Feb 2019 14:50:02 UTC

Severity: normal

Done: Sarah Morgensen <iskarian <at> mgsn.dev>

Bug is archived. No further changes may be made.

Full log


Message #14 received at 34526 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Gerber <dg <at> atufi.org>
To: Jelle Licht <jlicht <at> fsfe.org>
Cc: 34526 <at> debbugs.gnu.org
Subject: Re: bug#34526: Updating node.js
Date: Tue, 19 Feb 2019 17:42:19 +0100
[Message part 1 (text/plain, inline)]
2019-02-18, Jelle Licht: 

> It seems that llhttp includes a build step for generating 
> C-files using TypeScript, making it a non-starter for proper 
> packaging in Guix. 
> 
> See https://github.com/nodejs/llhttp/issues/14 for more details, 
> but sadly no solution. 

What about statically linking llhttp's C "sources" included in 
node?   Building v11.10.0 succeeds with this:

[node-llhttp.patch (text/x-patch, inline)]
diff --git a/node.gypi b/node.gypi
index c07b5ea704..c08493efbe 100644
--- a/node.gypi
+++ b/node.gypi
@@ -174,6 +174,12 @@
       ],
     } ],
 
+    [ 'node_shared_http_parser=="true"', {
+      'dependencies': [
+        'deps/llhttp/llhttp.gyp:llhttp'
+      ],
+    } ],
+
     [ 'node_shared_cares=="false"', {
       'dependencies': [ 'deps/cares/cares.gyp:cares' ],
     }],

This bug report was last modified 3 years and 242 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.