GNU bug report logs - #34527
27.0.50; Cygwin now has timer_getoverrun

Previous Next

Package: emacs;

Reported by: Ken Brown <kbrown <at> cornell.edu>

Date: Mon, 18 Feb 2019 15:18:02 UTC

Severity: normal

Found in version 27.0.50

Done: Ken Brown <kbrown <at> cornell.edu>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34527 in the body.
You can then email your comments to 34527 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#34527; Package emacs. (Mon, 18 Feb 2019 15:18:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Ken Brown <kbrown <at> cornell.edu>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 18 Feb 2019 15:18:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 27.0.50; Cygwin now has timer_getoverrun
Date: Mon, 18 Feb 2019 15:16:32 +0000

[Message part 1 (text/plain, inline)]
The latest release of Cygwin supports the timer_getoverrun function, so
there's no longer a need for the workaround in profiler.c that defines
timer_getoverrun as a macro.  The attached patch causes the function to
be used rather than the macro when it exists.

OK for master?

Ken

[0001-Use-timer_getoverrun-on-Cygwin-when-possible.patch (text/plain, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#34527; Package emacs. (Mon, 18 Feb 2019 16:22:01 GMT) Full text and rfc822 format available.

Message #8 received at 34527 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: 34527 <at> debbugs.gnu.org
Subject: Re: bug#34527: 27.0.50; Cygwin now has timer_getoverrun
Date: Mon, 18 Feb 2019 18:21:24 +0200

> From: Ken Brown <kbrown <at> cornell.edu>
> Date: Mon, 18 Feb 2019 15:16:32 +0000
> 
> The latest release of Cygwin supports the timer_getoverrun function, so
> there's no longer a need for the workaround in profiler.c that defines
> timer_getoverrun as a macro.  The attached patch causes the function to
> be used rather than the macro when it exists.
> 
> OK for master?

LGTM, thanks.

Is there any user-visible effect of this change?  If so, please say
something in NEWS.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#34527; Package emacs. (Mon, 18 Feb 2019 17:15:01 GMT) Full text and rfc822 format available.

Message #11 received at 34527 <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: "34527 <at> debbugs.gnu.org" <34527 <at> debbugs.gnu.org>
Subject: Re: bug#34527: 27.0.50; Cygwin now has timer_getoverrun
Date: Mon, 18 Feb 2019 17:14:35 +0000

On 2/18/2019 11:21 AM, Eli Zaretskii wrote:
>> From: Ken Brown <kbrown <at> cornell.edu>
>> Date: Mon, 18 Feb 2019 15:16:32 +0000
>>
>> The latest release of Cygwin supports the timer_getoverrun function, so
>> there's no longer a need for the workaround in profiler.c that defines
>> timer_getoverrun as a macro.  The attached patch causes the function to
>> be used rather than the macro when it exists.
>>
>> OK for master?
> 
> LGTM, thanks.
> 
> Is there any user-visible effect of this change?

I don't think so.  I think it simply means that profiling will potentially be 
more accurate.  That's probably not NEWSworthy.

Ken
Reply sent to Ken Brown <kbrown <at> cornell.edu>:
You have taken responsibility. (Fri, 22 Feb 2019 14:23:01 GMT) Full text and rfc822 format available.
Notification sent to Ken Brown <kbrown <at> cornell.edu>:
bug acknowledged by developer. (Fri, 22 Feb 2019 14:23:02 GMT) Full text and rfc822 format available.

Message #16 received at 34527-done <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
Cc: "34527-done <at> debbugs.gnu.org" <34527-done <at> debbugs.gnu.org>
Subject: Re: bug#34527: 27.0.50; Cygwin now has timer_getoverrun
Date: Fri, 22 Feb 2019 14:22:27 +0000

Closing.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 23 Mar 2019 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 6 years and 93 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.