GNU bug report logs - #34382
[PATCH 4/5] gnu: Add python-docstyle.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#34382: closed ([PATCH 4/5] gnu: Add python-docstyle.)
Date: Tue, 12 Feb 2019 22:34:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 12 Feb 2019 23:33:36 +0100
with message-id <87sgwsfxhb.fsf <at> gnu.org>
and subject line Re: [bug#34382] [PATCH 4/5] gnu: Add python-docstyle.
has caused the debbugs.gnu.org bug report #34382,
regarding [PATCH 4/5] gnu: Add python-docstyle.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
34382: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34382
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Brett Gilio <brettg <at> posteo.net>
To: guix-patches <at> gnu.org
Subject: [PATCH 4/5] gnu: Add python-docstyle.
Date: Thu, 07 Feb 2019 22:10:00 -0600

[0004-gnu-Add-python-docstyle.patch (text/x-patch, inline)]

From 0b66f38dd41230611cad44181a81bda38e40619f Mon Sep 17 00:00:00 2001
From: Brett Gilio <brettg <at> posteo.net>
Date: Thu, 7 Feb 2019 22:04:52 -0600
Subject: [PATCH 4/5] gnu: Add python-docstyle.

* gnu/packages/python-xyz.scm (python-docstyle): New variable.
---
 gnu/packages/python-xyz.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 5c7241621..c41c4a1cd 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -2545,6 +2545,27 @@ Language (TOML) configuration files.")
   (description "An implementation of the JSON RPC 2.0 server library for interoperability with Python.")
   (license license:expat)))
 
+(define-public python-pydocstyle
+  (package
+  (name "python-pydocstyle")
+  (version "3.0.0")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (pypi-uri "pydocstyle" version))
+      (sha256
+        (base32
+          "1m1xv9clkg9lgzyza6dnj359z04vh5g0h49nhzghv7lg81gchhap"))))
+  (build-system python-build-system)
+  (propagated-inputs
+   `(("python-six" ,python-six)
+     ("python-snowballstemmer" ,python-snowballstemmer)))
+  (home-page
+    "https://github.com/PyCQA/pydocstyle/")
+  (synopsis "Python docstring style checker")
+  (description "A docstring style checker/linter for the Python language server.")
+  (license license:expat)))
+
 (define-public python-black
   (package
     (name "python-black")
-- 
2.20.1

[Message part 4 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Brett Gilio <brettg <at> posteo.net>
Cc: 34382-done <at> debbugs.gnu.org
Subject: Re: [bug#34382] [PATCH 4/5] gnu: Add python-docstyle.
Date: Tue, 12 Feb 2019 23:33:36 +0100

Brett Gilio <brettg <at> posteo.net> skribis:

>>From 0b66f38dd41230611cad44181a81bda38e40619f Mon Sep 17 00:00:00 2001
> From: Brett Gilio <brettg <at> posteo.net>
> Date: Thu, 7 Feb 2019 22:04:52 -0600
> Subject: [PATCH 4/5] gnu: Add python-docstyle.
>
> * gnu/packages/python-xyz.scm (python-docstyle): New variable.

Pushed as well.

This series ended up taking me more time than I thought.  :-)
First the patches were sent in reverse order, which I only realized
later.  Then each patch had tiny issues (indentation, inappropriate
description, code duplication, etc.) that I ended up fixing because they
looked tiny at first…

Please pay more attention to these things in the future.

Regardless, thank you for the patches!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.