GNU bug report logs - #34382
[PATCH 4/5] gnu: Add python-docstyle.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34382 in the body.
You can then email your comments to 34382 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> posteo.net>
To: guix-patches <at> gnu.org
Subject: [PATCH 4/5] gnu: Add python-docstyle.
Date: Thu, 07 Feb 2019 22:10:00 -0600

[0004-gnu-Add-python-docstyle.patch (text/x-patch, inline)]

From 0b66f38dd41230611cad44181a81bda38e40619f Mon Sep 17 00:00:00 2001
From: Brett Gilio <brettg <at> posteo.net>
Date: Thu, 7 Feb 2019 22:04:52 -0600
Subject: [PATCH 4/5] gnu: Add python-docstyle.

* gnu/packages/python-xyz.scm (python-docstyle): New variable.
---
 gnu/packages/python-xyz.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 5c7241621..c41c4a1cd 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -2545,6 +2545,27 @@ Language (TOML) configuration files.")
   (description "An implementation of the JSON RPC 2.0 server library for interoperability with Python.")
   (license license:expat)))
 
+(define-public python-pydocstyle
+  (package
+  (name "python-pydocstyle")
+  (version "3.0.0")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (pypi-uri "pydocstyle" version))
+      (sha256
+        (base32
+          "1m1xv9clkg9lgzyza6dnj359z04vh5g0h49nhzghv7lg81gchhap"))))
+  (build-system python-build-system)
+  (propagated-inputs
+   `(("python-six" ,python-six)
+     ("python-snowballstemmer" ,python-snowballstemmer)))
+  (home-page
+    "https://github.com/PyCQA/pydocstyle/")
+  (synopsis "Python docstring style checker")
+  (description "A docstring style checker/linter for the Python language server.")
+  (license license:expat)))
+
 (define-public python-black
   (package
     (name "python-black")
-- 
2.20.1

Message #10 received at 34382-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Brett Gilio <brettg <at> posteo.net>
Cc: 34382-done <at> debbugs.gnu.org
Subject: Re: [bug#34382] [PATCH 4/5] gnu: Add python-docstyle.
Date: Tue, 12 Feb 2019 23:33:36 +0100

Brett Gilio <brettg <at> posteo.net> skribis:

>>From 0b66f38dd41230611cad44181a81bda38e40619f Mon Sep 17 00:00:00 2001
> From: Brett Gilio <brettg <at> posteo.net>
> Date: Thu, 7 Feb 2019 22:04:52 -0600
> Subject: [PATCH 4/5] gnu: Add python-docstyle.
>
> * gnu/packages/python-xyz.scm (python-docstyle): New variable.

Pushed as well.

This series ended up taking me more time than I thought.  :-)
First the patches were sent in reverse order, which I only realized
later.  Then each patch had tiny issues (indentation, inappropriate
description, code duplication, etc.) that I ended up fixing because they
looked tiny at first…

Please pay more attention to these things in the future.

Regardless, thank you for the patches!

Ludo’.

Message #13 received at 34382-done <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> posteo.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 34382-done <at> debbugs.gnu.org, Brett Gilio <brettg <at> posteo.net>
Subject: Re: [bug#34382] [PATCH 4/5] gnu: Add python-docstyle.
Date: Tue, 12 Feb 2019 18:50:22 -0600

Ludovic Courtès writes:

> Brett Gilio <brettg <at> posteo.net> skribis:
>
>>>From 0b66f38dd41230611cad44181a81bda38e40619f Mon Sep 17 00:00:00 2001
>> From: Brett Gilio <brettg <at> posteo.net>
>> Date: Thu, 7 Feb 2019 22:04:52 -0600
>> Subject: [PATCH 4/5] gnu: Add python-docstyle.
>>
>> * gnu/packages/python-xyz.scm (python-docstyle): New variable.
>
> Pushed as well.
>
> This series ended up taking me more time than I thought.  :-)
> First the patches were sent in reverse order, which I only realized
> later.  Then each patch had tiny issues (indentation, inappropriate
> description, code duplication, etc.) that I ended up fixing because they
> looked tiny at first…
>
> Please pay more attention to these things in the future.
>
> Regardless, thank you for the patches!
>
> Ludo’.

Thank you Ludo,

This was my first series, so I appreciate the comments you gave me for
feedback and I will be more diligent in the future!

Brett

Message #16 received at 34382-done <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> posteo.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 34382-done <at> debbugs.gnu.org, Brett Gilio <brettg <at> posteo.net>
Subject: Re: [bug#34382] [PATCH 4/5] gnu: Add python-docstyle.
Date: Tue, 12 Feb 2019 18:51:27 -0600

Ludovic Courtès writes:

> Brett Gilio <brettg <at> posteo.net> skribis:
>
>>>From 0b66f38dd41230611cad44181a81bda38e40619f Mon Sep 17 00:00:00 2001
>> From: Brett Gilio <brettg <at> posteo.net>
>> Date: Thu, 7 Feb 2019 22:04:52 -0600
>> Subject: [PATCH 4/5] gnu: Add python-docstyle.
>>
>> * gnu/packages/python-xyz.scm (python-docstyle): New variable.
>
> Pushed as well.
>
> This series ended up taking me more time than I thought.  :-)
> First the patches were sent in reverse order, which I only realized
> later.  Then each patch had tiny issues (indentation, inappropriate
> description, code duplication, etc.) that I ended up fixing because they
> looked tiny at first…
>
> Please pay more attention to these things in the future.
>
> Regardless, thank you for the patches!
>
> Ludo’.

This was my first patch series, so I appreciate your feedback to help me
make sure that I am doing this correct in the future!

Thank you as always

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.