GNU bug report logs - #34358
[PATCH] gnu: python@2.7: Honor NIX_STORE.

Previous Next

Full log

View this message in rfc822 format

From: Caleb Ristvedt <caleb.ristvedt <at> cune.org>
To: 34358 <at> debbugs.gnu.org, ludo <at> gnu.org
Subject: [bug#34358] [PATCH] gnu: python <at> 2.7: Honor NIX_STORE.
Date: Wed, 06 Feb 2019 18:07:21 -0600

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Perhaps in the future you could email guix-patches <at> gnu.org for specific
> commits like this one, especially when it’s not strictly related to the
> daemon?

...

> Could you send an updated version of the patch?

Here it is!

> ./configure does not generate any patch files based on patch templates,
> and that’s on purpose.  Instead, when we need something like this, we
> handle it the way ld-wrapper.in is handled: by doing the substitution
> when creating the derivation.

"When creating the derivation" sounds like it's when the package is lowered
to a derivation, but from what I can see of ld-wrapper in (gnu packages
base) the actual substitution is done when the derivation is built. I
am curious how one would go about doing the substitution when the
package is lowered to a derivation, though. Anyway, for now I'm doing
the substitution at derivation-build-time.

> Last, the patch would need to go to ‘core-updates’ because of the number
> of rebuilds it entails.

Should I mention this somewhere?

Also, I should add that "guix lint" and indent-code.el both want changes
to gnu/packages/python.scm, but not due to changes I made. Should a
separate patch address those?

- reepca

[0001-gnu-python-2.7-Honor-NIX_STORE.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.